From: Oliver Neukum <oneukum@suse.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>, jslaby@suse.com
Subject: Re: Hangs in r8152 connected to power management in kernels at least up v4.17-rc4
Date: Wed, 16 May 2018 12:09:51 +0200 [thread overview]
Message-ID: <1526465391.25281.7.camel@suse.com> (raw)
In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2D2E47EB4@RTITMBSV06.realtek.com.tw>
Am Mittwoch, den 16.05.2018, 10:00 +0000 schrieb Hayes Wang:
> Oliver Neukum [mailto:oneukum@suse.com]
> > Sent: Wednesday, May 16, 2018 4:27 PM
>
> [...]
> > >
> > > Would usb_autopm_get_interface() take a long time?
> > > The driver would wake the device if it has suspended.
> > > I have no idea about how usb_autopm_get_interface() works, so I don't know
> >
> > how to help.
> >
> > Hi,
> >
> > it basically calls r8152_resume() and makes a control request to the
> > hub. I think we are spinning in rtl8152_runtime_resume(), but where?
> > It has a lot of NAPI stuff. Any suggestions on how to instrument or
> > trace this?
>
> Is rtl8152_runtime_resume() called? I don't see the name in the trace.
Good question. I see nothing else that could produce a live lock.
>
> I guess the relative API in rtl8152_runtime_resume() are
> ops->disable = rtl8153_disable;
> ops->autosuspend_en = rtl8153_runtime_enable;
>
> And I don't find any possible dead lock in rtl8152_runtime_resume().
>
> Besides, I find a similar issue as following.
> https://www.spinics.net/lists/netdev/msg493512.html
Well, if we have an imbalance in NAPI it should strike whereever
it is used, not just in suspend(). Is there debugging for NAPI
we could activate?
Regards
Oliver
next prev parent reply other threads:[~2018-05-16 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 12:43 Hangs in r8152 connected to power management in kernels at least up v4.17-rc4 Oliver Neukum
2018-05-16 3:37 ` Hayes Wang
2018-05-16 8:26 ` Oliver Neukum
2018-05-16 10:00 ` Hayes Wang
2018-05-16 10:09 ` Oliver Neukum [this message]
2018-05-16 12:07 ` Hayes Wang
2018-05-16 13:29 ` Jiri Slaby
2018-05-16 13:36 ` Jiri Slaby
2018-05-25 8:41 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526465391.25281.7.camel@suse.com \
--to=oneukum@suse.com \
--cc=hayeswang@realtek.com \
--cc=jslaby@suse.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).