From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amritha Nambiar Subject: [net PATCH] net: Fix a bug in removing queues from XPS map Date: Thu, 17 May 2018 14:50:44 -0700 Message-ID: <152659384481.2834.5040004714298449412.stgit@anamdev.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: alexander.h.duyck@intel.com, f.fainelli@gmail.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, edumazet@google.com, hannes@stressinduktion.org, tom@herbertland.com To: netdev@vger.kernel.org, davem@davemloft.net Return-path: Received: from mga11.intel.com ([192.55.52.93]:30913 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbeEQVyN (ORCPT ); Thu, 17 May 2018 17:54:13 -0400 Sender: netdev-owner@vger.kernel.org List-ID: While removing queues from the XPS map, the individual CPU ID alone was used to index the CPUs map, this should be changed to also factor in the traffic class mapping for the CPU-to-queue lookup. Fixes: 184c449f91fe ("net: Add support for XPS with QoS via traffic classes") Signed-off-by: Amritha Nambiar Acked-by: Alexander Duyck --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 9f43901..9397577 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2125,7 +2125,7 @@ static bool remove_xps_queue_cpu(struct net_device *dev, int i, j; for (i = count, j = offset; i--; j++) { - if (!remove_xps_queue(dev_maps, cpu, j)) + if (!remove_xps_queue(dev_maps, tci, j)) break; }