From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yongjun Subject: [PATCH net-next] virtio_net: fix error return code in virtnet_probe() Date: Thu, 31 May 2018 02:05:07 +0000 Message-ID: <1527732307-145609-1-git-send-email-weiyongjun1@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Wei Yongjun , , , To: "Michael S. Tsirkin" , Jason Wang , Sridhar Samudrala Return-path: Received: from szxga07-in.huawei.com ([45.249.212.35]:47322 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932570AbeEaB6W (ORCPT ); Wed, 30 May 2018 21:58:22 -0400 Sender: netdev-owner@vger.kernel.org List-ID: Fix to return a negative error code from the failover create fail error handling case instead of 0, as done elsewhere in this function. Fixes: ba5e4426e80e ("virtio_net: Extend virtio to use VF datapath when available") Signed-off-by: Wei Yongjun --- drivers/net/virtio_net.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 8f08a3e..2d55e2a 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2935,8 +2935,10 @@ static int virtnet_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) { vi->failover = net_failover_create(vi->dev); - if (IS_ERR(vi->failover)) + if (IS_ERR(vi->failover)) { + err = PTR_ERR(vi->failover); goto free_vqs; + } } err = register_netdev(dev);