From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Blakey Subject: [PATCH net-next V2 2/2] cls_flower: Fix comparing of old filter mask with new filter Date: Sun, 3 Jun 2018 10:06:14 +0300 Message-ID: <1528009574-63306-2-git-send-email-paulb@mellanox.com> References: <1528009574-63306-1-git-send-email-paulb@mellanox.com> Cc: Yevgeny Kliteynik , Roi Dayan , Shahar Klein , Mark Bloch , Or Gerlitz , Paul Blakey To: Jiri Pirko , Cong Wang , Jamal Hadi Salim , David Miller , netdev@vger.kernel.org Return-path: Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:34222 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750818AbeFCHGW (ORCPT ); Sun, 3 Jun 2018 03:06:22 -0400 In-Reply-To: <1528009574-63306-1-git-send-email-paulb@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: We incorrectly compare the mask and the result is that we can't modify an already existing rule. Fix that by comparing correctly. Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") Reported-by: Vlad Buslov Reviewed-by: Roi Dayan Reviewed-by: Jiri Pirko Signed-off-by: Paul Blakey --- Changelog: v0 -> v2: rebased. net/sched/cls_flower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 159efd9..2b5be42 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -877,7 +877,7 @@ static int fl_check_assign_mask(struct cls_fl_head *head, return PTR_ERR(newmask); fnew->mask = newmask; - } else if (fold && fold->mask == fnew->mask) { + } else if (fold && fold->mask != fnew->mask) { return -EINVAL; } -- 2.7.4