netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tushar Dave <tushar.n.dave@oracle.com>
To: netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	davem@davemloft.net, john.fastabend@gmail.com,
	jakub.kicinski@netronome.com, kafai@fb.com, rdna@fb.com,
	quentin.monnet@netronome.com, brakmo@fb.com, acme@redhat.com
Subject: [RFC PATCH 3/3] rds: invoke sk filter attached to rds socket
Date: Fri,  8 Jun 2018 23:00:07 +0200	[thread overview]
Message-ID: <1528491607-10399-4-git-send-email-tushar.n.dave@oracle.com> (raw)
In-Reply-To: <1528491607-10399-1-git-send-email-tushar.n.dave@oracle.com>

RDS module sits on top of TCP (rds_tcp) and IB (rds_rdma), so messages
arrive in form of skb (over TCP) and scatterlist (over IB/RDMA).
However, because socket filter only deal with skb (e.g. struct skb as
bpf context) we can only use socket filter for rds_tcp and not for
rds_rdma. For that reason this patch invokes socket filter only for
rds socket with tcp transport e.g. rds_tcp.

note:
BTW, we dont want rds-core to be polluted by module-specific data
structures e.g. we included tcp.h to retrieve rds_tcp specific
structures. For non-RFC version we will add a way to get transport
specific indirections to get the skb.

Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com>
Reviewed-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
---
 net/rds/recv.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/net/rds/recv.c b/net/rds/recv.c
index dc67458..3be9628 100644
--- a/net/rds/recv.c
+++ b/net/rds/recv.c
@@ -39,6 +39,7 @@
 #include <linux/rds.h>
 
 #include "rds.h"
+#include "tcp.h"
 
 void rds_inc_init(struct rds_incoming *inc, struct rds_connection *conn,
 		  __be32 saddr)
@@ -369,6 +370,22 @@ void rds_recv_incoming(struct rds_connection *conn, __be32 saddr, __be32 daddr,
 	/* We can be racing with rds_release() which marks the socket dead. */
 	sk = rds_rs_to_sk(rs);
 
+	if (rs->rs_transport->t_type == RDS_TRANS_TCP) {
+		struct sk_buff *skb;
+		struct sk_filter *filter = sk->sk_filter;
+		struct rds_tcp_incoming *tinc;
+
+		tinc = container_of(inc, struct rds_tcp_incoming, ti_inc);
+		skb = tinc->ti_skb_list.next;
+		rcu_read_lock();
+		filter = rcu_dereference(sk->sk_filter);
+		if (filter) {
+			bpf_compute_data_pointers(skb);
+			bpf_prog_run_save_cb(filter->prog, skb);
+		}
+		rcu_read_unlock();
+	}
+
 	/* serialize with rds_release -> sock_orphan */
 	write_lock_irqsave(&rs->rs_recv_lock, flags);
 	if (!sock_flag(sk, SOCK_DEAD)) {
-- 
1.8.3.1

      parent reply	other threads:[~2018-06-08 21:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 21:00 [RFC PATCH 0/3] BPF socket filter to deal with skb frags Tushar Dave
2018-06-08 21:00 ` [RFC PATCH 1/3] ebpf: add next_skb_frag bpf helper for sk filter Tushar Dave
2018-06-08 21:27   ` Daniel Borkmann
2018-06-08 21:46     ` Tushar Dave
2018-06-08 22:24       ` Tushar Dave
2018-06-08 21:00 ` [RFC PATCH 2/3] samples/bpf: add sample RDS program Tushar Dave
2018-06-08 21:00 ` Tushar Dave [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1528491607-10399-4-git-send-email-tushar.n.dave@oracle.com \
    --to=tushar.n.dave@oracle.com \
    --cc=acme@redhat.com \
    --cc=ast@kernel.org \
    --cc=brakmo@fb.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=quentin.monnet@netronome.com \
    --cc=rdna@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).