From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhouyang Jia Subject: [PATCH] isdn/i4l: add error handling for try_module_get Date: Tue, 12 Jun 2018 12:43:53 +0800 Message-ID: <1528778635-41763-1-git-send-email-jiazhouyang09@gmail.com> Cc: Zhouyang Jia , Karsten Keil , Kees Cook , Annie Cherkaev , Al Viro , Jiten Thakkar , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: unlisted-recipients:; (no To-header on input) Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org When try_module_get fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling try_module_get. Signed-off-by: Zhouyang Jia --- drivers/isdn/i4l/isdn_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/isdn/i4l/isdn_common.c b/drivers/isdn/i4l/isdn_common.c index 7c6f3f5..7e52851 100644 --- a/drivers/isdn/i4l/isdn_common.c +++ b/drivers/isdn/i4l/isdn_common.c @@ -71,7 +71,8 @@ static int isdn_add_channels(isdn_driver_t *d, int drvidx, int n, int adding); static inline void isdn_lock_driver(isdn_driver_t *drv) { - try_module_get(drv->interface->owner); + if (!try_module_get(drv->interface->owner)) + printk(KERN_WARNING "isdn_lock_driver: cannot get module\n"); drv->locks++; } -- 2.7.4