From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH v3] bitfield: fix *_encode_bits() Date: Mon, 18 Jun 2018 22:42:29 +0200 Message-ID: <1529354549.3092.36.camel@sipsolutions.net> References: <20180618195618.17536-1-johannes@sipsolutions.net> <1529353683.3092.32.camel@sipsolutions.net> (sfid-20180618_224029_738852_AF216451) Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Linux Kernel Mailing List , netdev , Al Viro To: Andy Shevchenko Return-path: In-Reply-To: (sfid-20180618_224029_738852_AF216451) Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 2018-06-18 at 23:40 +0300, Andy Shevchenko wrote: > The idea is to print what was the input, expected output and actual result. > Then you would see what exactly is broken. Yeah, I guess we could. I did some of that work. > I dunno how much we may take away from this certain test case, though > it would be better for my opinion. TBH though, I'm not sure I want to do this (right now at least). I don't think we gain anything from it, it's so basic ... so to me it's just pointless extra code. johannes