netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shannon Nelson <shannon.nelson@oracle.com>
To: netdev@vger.kernel.org, davem@davemloft.net, anders.roxell@linaro.org
Subject: [PATCH net-next 1/2] selftests: rtnetlink: hide complaint from terminated monitor
Date: Tue, 19 Jun 2018 22:42:42 -0700	[thread overview]
Message-ID: <1529473363-4036-2-git-send-email-shannon.nelson@oracle.com> (raw)
In-Reply-To: <1529473363-4036-1-git-send-email-shannon.nelson@oracle.com>

Set up the "ip xfrm monitor" subprogram so as to not see
a "Terminated" message when the subprogram is killed.

Fixes: 5e596ee171ba ("selftests: add xfrm state-policy-monitor to rtnetlink.sh")
Reported-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
---
 tools/testing/selftests/net/rtnetlink.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
index 760faef..0a2bc6e 100755
--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -532,8 +532,7 @@ kci_test_ipsec()
 
 	# start the monitor in the background
 	tmpfile=`mktemp ipsectestXXX`
-	ip x m > $tmpfile &
-	mpid=$!
+	mpid=`(ip x m > $tmpfile & echo $!) 2>/dev/null`
 	sleep 0.2
 
 	ipsecid="proto esp src $srcip dst $dstip spi 0x07"
-- 
2.7.4

  reply	other threads:[~2018-06-20  5:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  5:42 [PATCH net-next 0/2] fixes for ipsec selftests Shannon Nelson
2018-06-20  5:42 ` Shannon Nelson [this message]
2018-06-20  5:42 ` [PATCH net-next 2/2] selftests: rtnetlink: use a local IP address for IPsec tests Shannon Nelson
2018-06-20 19:09 ` [PATCH net-next 0/2] fixes for ipsec selftests Anders Roxell
2018-06-20 22:26   ` Shannon Nelson
2018-06-20 23:18     ` Anders Roxell
2018-06-21  0:32       ` Shannon Nelson
2018-06-21 16:56         ` Anders Roxell
2018-06-21 17:25           ` Shannon Nelson
2018-06-22  4:49 ` David Miller
2018-06-22  6:50   ` Shannon Nelson
2018-06-22  7:27     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529473363-4036-2-git-send-email-shannon.nelson@oracle.com \
    --to=shannon.nelson@oracle.com \
    --cc=anders.roxell@linaro.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).