* [PATCH net-next] net: phy: fixed-phy: Make the error path simpler
@ 2018-06-24 0:28 Fabio Estevam
2018-06-24 7:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2018-06-24 0:28 UTC (permalink / raw)
To: davem; +Cc: andrew, f.fainelli, netdev, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
When platform_device_register_simple() fails we can return
the error immediately instead of jumping to the 'err_pdev'
label.
This makes the error path a bit simpler.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/net/phy/fixed_phy.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
index 001fe1d..67b2608 100644
--- a/drivers/net/phy/fixed_phy.c
+++ b/drivers/net/phy/fixed_phy.c
@@ -259,10 +259,8 @@ static int __init fixed_mdio_bus_init(void)
int ret;
pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0);
- if (IS_ERR(pdev)) {
- ret = PTR_ERR(pdev);
- goto err_pdev;
- }
+ if (IS_ERR(pdev))
+ return PTR_ERR(pdev);
fmb->mii_bus = mdiobus_alloc();
if (fmb->mii_bus == NULL) {
@@ -287,7 +285,6 @@ static int __init fixed_mdio_bus_init(void)
mdiobus_free(fmb->mii_bus);
err_mdiobus_reg:
platform_device_unregister(pdev);
-err_pdev:
return ret;
}
module_init(fixed_mdio_bus_init);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: phy: fixed-phy: Make the error path simpler
2018-06-24 0:28 [PATCH net-next] net: phy: fixed-phy: Make the error path simpler Fabio Estevam
@ 2018-06-24 7:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-06-24 7:42 UTC (permalink / raw)
To: festevam; +Cc: andrew, f.fainelli, netdev, fabio.estevam
From: Fabio Estevam <festevam@gmail.com>
Date: Sat, 23 Jun 2018 21:28:22 -0300
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> When platform_device_register_simple() fails we can return
> the error immediately instead of jumping to the 'err_pdev'
> label.
>
> This makes the error path a bit simpler.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-24 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-24 0:28 [PATCH net-next] net: phy: fixed-phy: Make the error path simpler Fabio Estevam
2018-06-24 7:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).