From mboxrd@z Thu Jan 1 00:00:00 1970 From: xiangxia.m.yue@gmail.com Subject: [PATCH net-next v4 2/4] net: vhost: replace magic number of lock annotation Date: Mon, 2 Jul 2018 05:57:06 -0700 Message-ID: <1530536228-17462-3-git-send-email-xiangxia.m.yue@gmail.com> References: <1530536228-17462-1-git-send-email-xiangxia.m.yue@gmail.com> Cc: mst@redhat.com, makita.toshiaki@lab.ntt.co.jp, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, Tonghao Zhang , Tonghao Zhang To: jasowang@redhat.com Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:39163 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403AbeGBM4o (ORCPT ); Mon, 2 Jul 2018 08:56:44 -0400 Received: by mail-pf0-f196.google.com with SMTP id s21-v6so7491085pfm.6 for ; Mon, 02 Jul 2018 05:56:44 -0700 (PDT) In-Reply-To: <1530536228-17462-1-git-send-email-xiangxia.m.yue@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Tonghao Zhang Use the VHOST_NET_VQ_XXX as a subclass for mutex_lock_nested. Signed-off-by: Tonghao Zhang Acked-by: Jason Wang --- drivers/vhost/net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index e7cf7d2..62bb8e8 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -484,7 +484,7 @@ static void handle_tx(struct vhost_net *net) bool zcopy, zcopy_used; int sent_pkts = 0; - mutex_lock(&vq->mutex); + mutex_lock_nested(&vq->mutex, VHOST_NET_VQ_TX); sock = vq->private_data; if (!sock) goto out; @@ -655,7 +655,7 @@ static int vhost_net_rx_peek_head_len(struct vhost_net *net, struct sock *sk) /* Flush batched heads first */ vhost_rx_signal_used(rvq); /* Both tx vq and rx socket were polled here */ - mutex_lock_nested(&vq->mutex, 1); + mutex_lock_nested(&vq->mutex, VHOST_NET_VQ_TX); vhost_disable_notify(&net->dev, vq); preempt_disable(); @@ -789,7 +789,7 @@ static void handle_rx(struct vhost_net *net) __virtio16 num_buffers; int recv_pkts = 0; - mutex_lock_nested(&vq->mutex, 0); + mutex_lock_nested(&vq->mutex, VHOST_NET_VQ_RX); sock = vq->private_data; if (!sock) goto out; -- 1.8.3.1