From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rishabh Bhatnagar Subject: [PATCH] lib: rhashtable: Correct self-assignment in rhashtable.c Date: Mon, 2 Jul 2018 09:35:34 -0700 Message-ID: <1530549334-13890-1-git-send-email-rishabhb@codeaurora.org> Cc: linux-arm-msm@vger.kernel.org, Rishabh Bhatnagar To: netdev@vger.kernel.org, neilb@suse.com, tgraf@suug.ch, herbert@gondor.apana.org.au Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35406 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752378AbeGBQgI (ORCPT ); Mon, 2 Jul 2018 12:36:08 -0400 Sender: netdev-owner@vger.kernel.org List-ID: In file lib/rhashtable.c line 777, skip variable is assigned to itself. The following error was observed: lib/rhashtable.c:777:41: warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign] error, forbidden warning: rhashtable.c:777 This error was found when compiling with Clang 6.0. Change it to iter->skip. Signed-off-by: Rishabh Bhatnagar Acked-by: Herbert Xu Reviewed-by: NeilBrown --- lib/rhashtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rhashtable.c b/lib/rhashtable.c index 9427b57..3109b2e 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c @@ -774,7 +774,7 @@ int rhashtable_walk_start_check(struct rhashtable_iter *iter) skip++; if (list == iter->list) { iter->p = p; - skip = skip; + iter->skip = skip; goto found; } } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project