netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
	Stefano Brivio <sbrivio@redhat.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	WANG Cong <xiyou.wangcong@gmail.com>,
	YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>,
	Flavio Leitner <fbl@redhat.com>,
	Hangbin Liu <liuhangbin@gmail.com>
Subject: [PATCHv2 net 0/2] multicast: init as INCLUDE when join SSM INCLUDE group
Date: Tue, 10 Jul 2018 22:41:25 +0800	[thread overview]
Message-ID: <1531233687-28744-1-git-send-email-liuhangbin@gmail.com> (raw)
In-Reply-To: <1528871551-17879-1-git-send-email-liuhangbin@gmail.com>

Based on RFC3376 5.1 and RFC3810 6.1, we should init as INCLUDE when join SSM
INCLUDE group. In my first version I only clear the group change record. But
this is not enough as when a new group join, it will init as EXCLUDE and
trigger an filter mode change in ip/ip6_mc_add_src(), which will clear all
source addresses' sf_crcount. This will prevent early joined address sending
state change records if multi source addresses joined at the same time.

In this v2 patchset, I fixed it by directly initializing the mode to INCLUDE
for SSM JOIN_SOURCE_GROUP. I also split the original patch into two separated
patches for IPv4 and IPv6.

Test: test by myself and customer.

Hangbin Liu (2):
  ipv4/igmp: init group mode as INCLUDE when join source group
  ipv6/mcast: init as INCLUDE when join SSM INCLUDE group

 include/linux/igmp.h     |  2 ++
 include/net/ipv6.h       |  2 ++
 net/ipv4/igmp.c          | 58 +++++++++++++++++++++++++++++++------------
 net/ipv4/ip_sockglue.c   |  4 +--
 net/ipv6/ipv6_sockglue.c |  5 ++--
 net/ipv6/mcast.c         | 64 ++++++++++++++++++++++++++++++++++--------------
 6 files changed, 96 insertions(+), 39 deletions(-)

-- 
2.5.5

  parent reply	other threads:[~2018-07-10 14:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13  6:32 [PATCH net] net/multicast: clean change record if add new INCLUDE group Hangbin Liu
2018-06-16  3:10 ` Hangbin Liu
2018-07-10 14:41 ` Hangbin Liu [this message]
2018-07-10 14:41   ` [PATCHv2 net 1/2] ipv4/igmp: init group mode as INCLUDE when join source group Hangbin Liu
2018-07-10 14:41   ` [PATCHv2 net 2/2] ipv6/mcast: init as INCLUDE when join SSM INCLUDE group Hangbin Liu
2018-07-16 18:20   ` [PATCHv2 net 0/2] multicast: " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531233687-28744-1-git-send-email-liuhangbin@gmail.com \
    --to=liuhangbin@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=fbl@redhat.com \
    --cc=hideaki.yoshifuji@miraclelinux.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbrivio@redhat.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).