netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Pismenny <borisp@mellanox.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, davejwatson@fb.com, aviadye@mellanox.com,
	borisp@mellanox.com, saeedm@mellanox.com
Subject: [PATCH v5 net-next 10/18] tls: Fix zerocopy_from_iter iov handling
Date: Fri, 13 Jul 2018 14:33:44 +0300	[thread overview]
Message-ID: <1531481632-12335-11-git-send-email-borisp@mellanox.com> (raw)
In-Reply-To: <1531481632-12335-1-git-send-email-borisp@mellanox.com>

zerocopy_from_iter iterates over the message, but it doesn't revert the
updates made by the iov iteration. This patch fixes it. Now, the iov can
be used after calling zerocopy_from_iter.

Fixes: 3c4d75591 ("tls: kernel TLS support")
Signed-off-by: Boris Pismenny <borisp@mellanox.com>
---
 net/tls/tls_sw.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index 2a6ba0f..ea78678 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -267,7 +267,7 @@ static int zerocopy_from_iter(struct sock *sk, struct iov_iter *from,
 			      int length, int *pages_used,
 			      unsigned int *size_used,
 			      struct scatterlist *to, int to_max_pages,
-			      bool charge)
+			      bool charge, bool revert)
 {
 	struct page *pages[MAX_SKB_FRAGS];
 
@@ -318,6 +318,8 @@ static int zerocopy_from_iter(struct sock *sk, struct iov_iter *from,
 out:
 	*size_used = size;
 	*pages_used = num_elem;
+	if (revert)
+		iov_iter_revert(from, size);
 
 	return rc;
 }
@@ -419,7 +421,7 @@ int tls_sw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
 				&ctx->sg_plaintext_size,
 				ctx->sg_plaintext_data,
 				ARRAY_SIZE(ctx->sg_plaintext_data),
-				true);
+				true, false);
 			if (ret)
 				goto fallback_to_reg_send;
 
@@ -834,7 +836,7 @@ int tls_sw_recvmsg(struct sock *sk,
 				err = zerocopy_from_iter(sk, &msg->msg_iter,
 							 to_copy, &pages,
 							 &chunk, &sgin[1],
-							 MAX_SKB_FRAGS,	false);
+							 MAX_SKB_FRAGS,	false, true);
 				if (err < 0)
 					goto fallback_to_reg_recv;
 
-- 
1.8.3.1

  parent reply	other threads:[~2018-07-13 11:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 11:33 [PATCH v5 net-next 00/18] TLS offload rx, netdev & mlx5 Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 01/18] net: Add decrypted field to skb Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 02/18] net: Add TLS RX offload feature Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 03/18] net: Add TLS rx resync NDO Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 04/18] tcp: Don't coalesce decrypted and encrypted SKBs Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 05/18] tls: Refactor tls_offload variable names Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 06/18] tls: Split decrypt_skb to two functions Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 07/18] tls: Split tls_sw_release_resources_rx Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 08/18] tls: Fill software context without allocation Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 09/18] tls: Add rx inline crypto offload Boris Pismenny
2018-07-13 11:33 ` Boris Pismenny [this message]
2018-07-13 11:33 ` [PATCH v5 net-next 11/18] net/mlx5e: TLS, refactor variable names Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 12/18] net/mlx5: Accel, add TLS rx offload routines Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 13/18] net/mlx5e: TLS, add innova rx support Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 14/18] net/mlx5e: TLS, add Innova TLS rx data path Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 15/18] net/mlx5e: TLS, add software statistics Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 16/18] net/mlx5e: TLS, build TLS netdev from capabilities Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 17/18] net/mlx5: Accel, add common metadata functions Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 18/18] net/mlx5e: IPsec, fix byte count in CQE Boris Pismenny
2018-07-16  7:17 ` [PATCH v5 net-next 00/18] TLS offload rx, netdev & mlx5 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531481632-12335-11-git-send-email-borisp@mellanox.com \
    --to=borisp@mellanox.com \
    --cc=aviadye@mellanox.com \
    --cc=davejwatson@fb.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).