netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Pismenny <borisp@mellanox.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, davejwatson@fb.com, aviadye@mellanox.com,
	borisp@mellanox.com, saeedm@mellanox.com
Subject: [PATCH v5 net-next 15/18] net/mlx5e: TLS, add software statistics
Date: Fri, 13 Jul 2018 14:33:49 +0300	[thread overview]
Message-ID: <1531481632-12335-16-git-send-email-borisp@mellanox.com> (raw)
In-Reply-To: <1531481632-12335-1-git-send-email-borisp@mellanox.com>

This patch adds software statistics for TLS to count important
events.

Signed-off-by: Boris Pismenny <borisp@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c      |  3 +++
 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h      |  4 ++++
 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c | 11 ++++++++++-
 3 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
index 68368c9..541e6f4 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
@@ -169,7 +169,10 @@ static void mlx5e_tls_resync_rx(struct net_device *netdev, struct sock *sk,
 
 	rx_ctx = mlx5e_get_tls_rx_context(tls_ctx);
 
+	netdev_info(netdev, "resyncing seq %d rcd %lld\n", seq,
+		    be64_to_cpu(rcd_sn));
 	mlx5_accel_tls_resync_rx(priv->mdev, rx_ctx->handle, seq, rcd_sn);
+	atomic64_inc(&priv->tls->sw_stats.rx_tls_resync_reply);
 }
 
 static const struct tlsdev_ops mlx5e_tls_ops = {
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h
index 2d40ede..3f5d721 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h
@@ -43,6 +43,10 @@ struct mlx5e_tls_sw_stats {
 	atomic64_t tx_tls_drop_resync_alloc;
 	atomic64_t tx_tls_drop_no_sync_data;
 	atomic64_t tx_tls_drop_bypass_required;
+	atomic64_t rx_tls_drop_resync_request;
+	atomic64_t rx_tls_resync_request;
+	atomic64_t rx_tls_resync_reply;
+	atomic64_t rx_tls_auth_fail;
 };
 
 struct mlx5e_tls {
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c
index d460fda..ecfc764 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c
@@ -330,8 +330,12 @@ static int tls_update_resync_sn(struct net_device *netdev,
 						netdev->ifindex, 0);
 #endif
 	}
-	if (!sk || sk->sk_state == TCP_TIME_WAIT)
+	if (!sk || sk->sk_state == TCP_TIME_WAIT) {
+		struct mlx5e_priv *priv = netdev_priv(netdev);
+
+		atomic64_inc(&priv->tls->sw_stats.rx_tls_drop_resync_request);
 		goto out;
+	}
 
 	skb->sk = sk;
 	skb->destructor = sock_edemux;
@@ -349,6 +353,7 @@ void mlx5e_tls_handle_rx_skb(struct net_device *netdev, struct sk_buff *skb,
 	struct ethhdr *old_eth;
 	struct ethhdr *new_eth;
 	__be16 *ethtype;
+	struct mlx5e_priv *priv;
 
 	/* Detect inline metadata */
 	if (skb->len < ETH_HLEN + MLX5E_METADATA_ETHER_LEN)
@@ -365,9 +370,13 @@ void mlx5e_tls_handle_rx_skb(struct net_device *netdev, struct sk_buff *skb,
 		break;
 	case SYNDROM_RESYNC_REQUEST:
 		tls_update_resync_sn(netdev, skb, mdata);
+		priv = netdev_priv(netdev);
+		atomic64_inc(&priv->tls->sw_stats.rx_tls_resync_request);
 		break;
 	case SYNDROM_AUTH_FAILED:
 		/* Authentication failure will be observed and verified by kTLS */
+		priv = netdev_priv(netdev);
+		atomic64_inc(&priv->tls->sw_stats.rx_tls_auth_fail);
 		break;
 	default:
 		/* Bypass the metadata header to others */
-- 
1.8.3.1

  parent reply	other threads:[~2018-07-13 11:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 11:33 [PATCH v5 net-next 00/18] TLS offload rx, netdev & mlx5 Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 01/18] net: Add decrypted field to skb Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 02/18] net: Add TLS RX offload feature Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 03/18] net: Add TLS rx resync NDO Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 04/18] tcp: Don't coalesce decrypted and encrypted SKBs Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 05/18] tls: Refactor tls_offload variable names Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 06/18] tls: Split decrypt_skb to two functions Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 07/18] tls: Split tls_sw_release_resources_rx Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 08/18] tls: Fill software context without allocation Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 09/18] tls: Add rx inline crypto offload Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 10/18] tls: Fix zerocopy_from_iter iov handling Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 11/18] net/mlx5e: TLS, refactor variable names Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 12/18] net/mlx5: Accel, add TLS rx offload routines Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 13/18] net/mlx5e: TLS, add innova rx support Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 14/18] net/mlx5e: TLS, add Innova TLS rx data path Boris Pismenny
2018-07-13 11:33 ` Boris Pismenny [this message]
2018-07-13 11:33 ` [PATCH v5 net-next 16/18] net/mlx5e: TLS, build TLS netdev from capabilities Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 17/18] net/mlx5: Accel, add common metadata functions Boris Pismenny
2018-07-13 11:33 ` [PATCH v5 net-next 18/18] net/mlx5e: IPsec, fix byte count in CQE Boris Pismenny
2018-07-16  7:17 ` [PATCH v5 net-next 00/18] TLS offload rx, netdev & mlx5 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531481632-12335-16-git-send-email-borisp@mellanox.com \
    --to=borisp@mellanox.com \
    --cc=aviadye@mellanox.com \
    --cc=davejwatson@fb.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).