From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claudiu Beznea Subject: [RFC PATCH 2/3] net: macb: move checksum clearing outside of spinlock Date: Wed, 18 Jul 2018 15:58:08 +0300 Message-ID: <1531918689-22658-3-git-send-email-claudiu.beznea@microchip.com> References: <1531918689-22658-1-git-send-email-claudiu.beznea@microchip.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , , Claudiu Beznea To: , Return-path: Received: from esa1.microchip.iphmx.com ([68.232.147.91]:3669 "EHLO esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726909AbeGRNgO (ORCPT ); Wed, 18 Jul 2018 09:36:14 -0400 In-Reply-To: <1531918689-22658-1-git-send-email-claudiu.beznea@microchip.com> Sender: netdev-owner@vger.kernel.org List-ID: Move checksum clearing outside of spinlock. The SKB is protected by networking lock (HARD_TX_LOCK()). Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 860436474c3e..1c12afe4a0ce 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -1662,6 +1662,11 @@ static netdev_tx_t macb_start_xmit(struct sk_buff *skb, struct net_device *dev) bool is_lso, is_udp = 0; netdev_tx_t ret = NETDEV_TX_OK; + if (macb_clear_csum(skb)) { + dev_kfree_skb_any(skb); + return ret; + } + is_lso = (skb_shinfo(skb)->gso_size != 0); if (is_lso) { @@ -1717,11 +1722,6 @@ static netdev_tx_t macb_start_xmit(struct sk_buff *skb, struct net_device *dev) return NETDEV_TX_BUSY; } - if (macb_clear_csum(skb)) { - dev_kfree_skb_any(skb); - goto unlock; - } - /* Map socket buffer for DMA transfer */ if (!macb_tx_map(bp, queue, skb, hdrlen)) { dev_kfree_skb_any(skb); -- 2.7.4