From mboxrd@z Thu Jan 1 00:00:00 1970 From: Camelia Groza Subject: [PATCH] net: phy: use generic clause 45 autonegotiation done Date: Wed, 18 Jul 2018 16:12:15 +0300 Message-ID: <1531919535-20269-1-git-send-email-camelia.groza@nxp.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Camelia Groza To: andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Only Clause 22 PHYs can use genphy_aneg_done(). Use genphy_c45_aneg_done() for PHYs that implement Clause 45 without the Clause 22 register set. This change follows the model of phy_restart_aneg() which differentiates between the two implementations in a similar way. Fixes: 41408ad519f7 ("net: phy: avoid genphy_aneg_done() for PHYs without clause 22 support") Signed-off-by: Camelia Groza --- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 537297d..4fcc703 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -151,7 +151,7 @@ int phy_aneg_done(struct phy_device *phydev) * implement Clause 22 registers */ if (phydev->is_c45 && !(phydev->c45_ids.devices_in_package & BIT(0))) - return -EINVAL; + return genphy_c45_aneg_done(phydev); return genphy_aneg_done(phydev); } -- 1.9.1