netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Tranchetti <stranche@codeaurora.org>
To: eric.dumazet@gmail.com, davem@davemloft.net, netdev@vger.kernel.org
Cc: Sean Tranchetti <stranche@codeaurora.org>,
	Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Subject: [PATCH net-next] net: gro: Initialize backlog NAPI's gro_list
Date: Fri, 20 Jul 2018 17:53:23 -0600	[thread overview]
Message-ID: <1532130803-15674-1-git-send-email-stranche@codeaurora.org> (raw)

When using RPS, the target CPU uses the backlog NAPI struct.
This NAPI struct needs the list initialized explicitly as normally
the list is initialized from netif_napi_add() on the netdevice.

Unable to handle kernel NULL pointer dereference at virtual address 00000008
Kernel BUG at ffffff9808909310 [verbose debug info unavailable]
PC is at napi_gro_flush+0x74/0x104
LR is at napi_gro_flush+0x70/0x104
[<ffffff9808909310>] napi_gro_flush+0x74/0x104
[<ffffff980890aa24>] net_rx_action+0x3f8/0x4d4
[<ffffff9807a81aac>] __do_softirq+0x144/0x468
[<ffffff9807ab1794>] irq_exit+0x118/0x144
[<ffffff9807b2ad68>] __handle_domain_irq+0x94/0xf8
[<ffffff9807a81884>] gic_handle_irq+0xd0/0x1b4

Fixes: d4546c2509b1 ("net: Convert GRO SKB handling to list_head.")
Signed-off-by: Sean Tranchetti <stranche@codeaurora.org>
Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
---
 net/core/dev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/dev.c b/net/core/dev.c
index 4f8b92d..6b76745 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -9556,6 +9556,7 @@ static int __init net_dev_init(void)
 
 		sd->backlog.poll = process_backlog;
 		sd->backlog.weight = weight_p;
+		INIT_LIST_HEAD(&sd->backlog.gro_list);
 	}
 
 	dev_boot_phase = 0;
-- 
1.9.1

             reply	other threads:[~2018-07-21  0:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 23:53 Sean Tranchetti [this message]
2018-07-21  6:34 ` [PATCH net-next] net: gro: Initialize backlog NAPI's gro_list David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532130803-15674-1-git-send-email-stranche@codeaurora.org \
    --to=stranche@codeaurora.org \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).