From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Tranchetti Subject: [PATCH net-next] net: gro: Initialize backlog NAPI's gro_list Date: Fri, 20 Jul 2018 17:53:23 -0600 Message-ID: <1532130803-15674-1-git-send-email-stranche@codeaurora.org> Cc: Sean Tranchetti , Subash Abhinov Kasiviswanathan To: eric.dumazet@gmail.com, davem@davemloft.net, netdev@vger.kernel.org Return-path: Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:21232 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727812AbeGUAu1 (ORCPT ); Fri, 20 Jul 2018 20:50:27 -0400 Sender: netdev-owner@vger.kernel.org List-ID: When using RPS, the target CPU uses the backlog NAPI struct. This NAPI struct needs the list initialized explicitly as normally the list is initialized from netif_napi_add() on the netdevice. Unable to handle kernel NULL pointer dereference at virtual address 00000008 Kernel BUG at ffffff9808909310 [verbose debug info unavailable] PC is at napi_gro_flush+0x74/0x104 LR is at napi_gro_flush+0x70/0x104 [] napi_gro_flush+0x74/0x104 [] net_rx_action+0x3f8/0x4d4 [] __do_softirq+0x144/0x468 [] irq_exit+0x118/0x144 [] __handle_domain_irq+0x94/0xf8 [] gic_handle_irq+0xd0/0x1b4 Fixes: d4546c2509b1 ("net: Convert GRO SKB handling to list_head.") Signed-off-by: Sean Tranchetti Signed-off-by: Subash Abhinov Kasiviswanathan --- net/core/dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/dev.c b/net/core/dev.c index 4f8b92d..6b76745 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -9556,6 +9556,7 @@ static int __init net_dev_init(void) sd->backlog.poll = process_backlog; sd->backlog.weight = weight_p; + INIT_LIST_HEAD(&sd->backlog.gro_list); } dev_boot_phase = 0; -- 1.9.1