From: Arun Parameswaran <arun.parameswaran@broadcom.com>
To: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Arun Parameswaran <arun.parameswaran@broadcom.com>
Subject: [PATCH 2/7] net: phy: Fix the register offsets in Broadcom iProc mdio mux driver
Date: Thu, 26 Jul 2018 11:36:19 -0700 [thread overview]
Message-ID: <1532630184-29450-3-git-send-email-arun.parameswaran@broadcom.com> (raw)
In-Reply-To: <1532630184-29450-1-git-send-email-arun.parameswaran@broadcom.com>
Modify the register offsets in the Broadcom iProc mdio mux to start
from the top of the register address space.
Earlier the base address specified was from the middle of the block's
register space. The base address will now point to the start of the
mdio's address space. The offsets have been fixed to match this.
Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
---
drivers/net/phy/mdio-mux-bcm-iproc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/phy/mdio-mux-bcm-iproc.c b/drivers/net/phy/mdio-mux-bcm-iproc.c
index 0831b71..dc65e95 100644
--- a/drivers/net/phy/mdio-mux-bcm-iproc.c
+++ b/drivers/net/phy/mdio-mux-bcm-iproc.c
@@ -22,7 +22,7 @@
#include <linux/mdio-mux.h>
#include <linux/delay.h>
-#define MDIO_PARAM_OFFSET 0x00
+#define MDIO_PARAM_OFFSET 0x23c
#define MDIO_PARAM_MIIM_CYCLE 29
#define MDIO_PARAM_INTERNAL_SEL 25
#define MDIO_PARAM_BUS_ID 22
@@ -30,15 +30,15 @@
#define MDIO_PARAM_PHY_ID 16
#define MDIO_PARAM_PHY_DATA 0
-#define MDIO_READ_OFFSET 0x04
+#define MDIO_READ_OFFSET 0x240
#define MDIO_READ_DATA_MASK 0xffff
-#define MDIO_ADDR_OFFSET 0x08
+#define MDIO_ADDR_OFFSET 0x244
-#define MDIO_CTRL_OFFSET 0x0C
+#define MDIO_CTRL_OFFSET 0x248
#define MDIO_CTRL_WRITE_OP 0x1
#define MDIO_CTRL_READ_OP 0x2
-#define MDIO_STAT_OFFSET 0x10
+#define MDIO_STAT_OFFSET 0x24c
#define MDIO_STAT_DONE 1
#define BUS_MAX_ADDR 32
--
1.9.1
next prev parent reply other threads:[~2018-07-26 18:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 18:36 [PATCH 0/7] Add clock config and pm support to bcm iProc mdio mux Arun Parameswaran
2018-07-26 18:36 ` [PATCH 1/7] dt-bindings: net: Fix Broadcom iProc mdio mux driver base address Arun Parameswaran
2018-07-26 19:01 ` Andrew Lunn
2018-07-26 19:15 ` Arun Parameswaran
2018-07-26 18:36 ` Arun Parameswaran [this message]
2018-07-26 19:06 ` [PATCH 2/7] net: phy: Fix the register offsets in Broadcom iProc mdio mux driver Andrew Lunn
2018-07-26 19:16 ` Arun Parameswaran
2018-07-26 19:25 ` Ray Jui
2018-07-26 19:29 ` Andrew Lunn
2018-07-26 18:36 ` [PATCH 3/7] arm64: dts: Fix the base address of the Broadcom iProc mdio mux Arun Parameswaran
2018-07-26 18:36 ` [PATCH 4/7] dt-bindings: net: Add clock handle to " Arun Parameswaran
2018-07-26 18:36 ` [PATCH 5/7] net: phy: Add support to configure clock in " Arun Parameswaran
2018-07-26 19:13 ` Andrew Lunn
2018-07-26 19:20 ` Arun Parameswaran
2018-07-26 19:26 ` Andrew Lunn
2018-07-26 20:00 ` Arun Parameswaran
2018-07-26 18:36 ` [PATCH 6/7] net: phy: Add pm support to Broadcom iProc mdio mux driver Arun Parameswaran
2018-07-26 19:16 ` Andrew Lunn
2018-07-26 18:36 ` [PATCH 7/7] net: phy: Add pm support for scan ctrl register to bcm mdio mux Arun Parameswaran
2018-07-26 19:20 ` Andrew Lunn
2018-07-26 19:33 ` Arun Parameswaran
2018-07-26 19:36 ` Andrew Lunn
2018-07-26 19:51 ` Arun Parameswaran
2018-07-26 18:52 ` [PATCH 0/7] Add clock config and pm support to bcm iProc " Andrew Lunn
2018-07-26 19:00 ` Arun Parameswaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532630184-29450-3-git-send-email-arun.parameswaran@broadcom.com \
--to=arun.parameswaran@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).