From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Safonov Subject: Re: [PATCH 06/18] netlink: Do not subscribe to non-existent groups Date: Fri, 27 Jul 2018 14:43:24 +0100 Message-ID: <1532699004.2679.9.camel@arista.com> References: <20180726023144.31066-1-dima@arista.com> <20180726023144.31066-7-dima@arista.com> <20180725.212258.182134114222639499.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, steffen.klassert@secunet.com, 0x7f454c46@gmail.com, netdev@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20180725.212258.182134114222639499.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 2018-07-25 at 21:22 -0700, David Miller wrote: > From: Dmitry Safonov > Date: Thu, 26 Jul 2018 03:31:32 +0100 > > > Make ABI more strict about subscribing to group > ngroups. > > Code doesn't check for that and it looks bogus. > > (one can subscribe to non-existing group) > > Still, it's possible to bind() to all possible groups with (-1) > > > > Cc: "David S. Miller" > > Cc: Herbert Xu > > Cc: Steffen Klassert > > Cc: netdev@vger.kernel.org > > Signed-off-by: Dmitry Safonov > > This really has nothing to do with adding a compat layer for xfrm, > and is a bug fix that should be submitted separately in it's own > right. Sure, will do. -- Thanks, Dmitry