From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yafang Shao Subject: [PATCH net-next 1/2] tcp: call tcp_drop() in tcp collapse Date: Sat, 28 Jul 2018 11:01:39 +0800 Message-ID: <1532746900-11710-1-git-send-email-laoar.shao@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yafang Shao To: edumazet@google.com, davem@davemloft.net Return-path: Received: from mail-pg1-f194.google.com ([209.85.215.194]:42835 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbeG1E1C (ORCPT ); Sat, 28 Jul 2018 00:27:02 -0400 Sender: netdev-owner@vger.kernel.org List-ID: When this SKB is dropped, we should add the counter sk_drops. That could help us better tracking this behavior. Signed-off-by: Yafang Shao --- net/ipv4/tcp_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index d51fa35..90f83eb 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -4802,7 +4802,7 @@ static struct sk_buff *tcp_collapse_one(struct sock *sk, struct sk_buff *skb, else rb_erase(&skb->rbnode, root); - __kfree_skb(skb); + tcp_drop(sk, skb); NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPRCVCOLLAPSED); return next; -- 1.8.3.1