From: Dmitry Safonov <dima@arista.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, rong.a.chen@intel.com,
0x7f454c46@gmail.com, herbert@gondor.apana.org.au,
steffen.klassert@secunet.com, netdev@vger.kernel.org
Subject: Re: [PATCH] netlink: Don't shift with UB on nlk->ngroups
Date: Mon, 30 Jul 2018 20:50:29 +0100 [thread overview]
Message-ID: <1532980229.2679.34.camel@arista.com> (raw)
In-Reply-To: <20180730.124330.538236571439983894.davem@davemloft.net>
On Mon, 2018-07-30 at 12:43 -0700, David Miller wrote:
> From: Dmitry Safonov <dima@arista.com>
> Date: Mon, 30 Jul 2018 18:32:36 +0100
>
> > On i386 nlk->ngroups might be 32 or 0. Which leads to UB, resulting
> in
> > hang during boot.
> > Check for 0 ngroups and use (unsigned long long) as a type to
> shift.
> >
> > Fixes: commit 7acf9d4237c46894e0fa0492dd96314a41742e84 ("netlink:
> Do not
> > subscribe to non-existent groups").
>
> Please, in the future, format your Fixes: tag correctly. No need
> to say the work "commit", please do not chop up the line no matter
> how long it is, and please provide 12 digits of SHA1_ID value, rather
> than the whole thing.
Oh, yeah, I have this in .gitconfig:
[core]
abbrev = 12
But I was formatting this not on my laptop and have managed to mislook.
Sorry about "commit" and the breakage.
> > Reported-by: kernel test robot <rong.a.chen@intel.com>
> > Signed-off-by: Dmitry Safonov <dima@arista.com>
>
> Applied, thank you.
Thank you.
prev parent reply other threads:[~2018-07-30 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180730173236.20968-1-dima@arista.com>
2018-07-30 19:43 ` [PATCH] netlink: Don't shift with UB on nlk->ngroups David Miller
2018-07-30 19:50 ` Dmitry Safonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532980229.2679.34.camel@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rong.a.chen@intel.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).