* Re: [PATCH] netlink: Don't shift with UB on nlk->ngroups
[not found] <20180730173236.20968-1-dima@arista.com>
@ 2018-07-30 19:43 ` David Miller
2018-07-30 19:50 ` Dmitry Safonov
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2018-07-30 19:43 UTC (permalink / raw)
To: dima
Cc: linux-kernel, rong.a.chen, 0x7f454c46, herbert, steffen.klassert,
netdev
From: Dmitry Safonov <dima@arista.com>
Date: Mon, 30 Jul 2018 18:32:36 +0100
> On i386 nlk->ngroups might be 32 or 0. Which leads to UB, resulting in
> hang during boot.
> Check for 0 ngroups and use (unsigned long long) as a type to shift.
>
> Fixes: commit 7acf9d4237c46894e0fa0492dd96314a41742e84 ("netlink: Do not
> subscribe to non-existent groups").
Please, in the future, format your Fixes: tag correctly. No need
to say the work "commit", please do not chop up the line no matter
how long it is, and please provide 12 digits of SHA1_ID value, rather
than the whole thing.
> Reported-by: kernel test robot <rong.a.chen@intel.com>
> Signed-off-by: Dmitry Safonov <dima@arista.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] netlink: Don't shift with UB on nlk->ngroups
2018-07-30 19:43 ` [PATCH] netlink: Don't shift with UB on nlk->ngroups David Miller
@ 2018-07-30 19:50 ` Dmitry Safonov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Safonov @ 2018-07-30 19:50 UTC (permalink / raw)
To: David Miller
Cc: linux-kernel, rong.a.chen, 0x7f454c46, herbert, steffen.klassert,
netdev
On Mon, 2018-07-30 at 12:43 -0700, David Miller wrote:
> From: Dmitry Safonov <dima@arista.com>
> Date: Mon, 30 Jul 2018 18:32:36 +0100
>
> > On i386 nlk->ngroups might be 32 or 0. Which leads to UB, resulting
> in
> > hang during boot.
> > Check for 0 ngroups and use (unsigned long long) as a type to
> shift.
> >
> > Fixes: commit 7acf9d4237c46894e0fa0492dd96314a41742e84 ("netlink:
> Do not
> > subscribe to non-existent groups").
>
> Please, in the future, format your Fixes: tag correctly. No need
> to say the work "commit", please do not chop up the line no matter
> how long it is, and please provide 12 digits of SHA1_ID value, rather
> than the whole thing.
Oh, yeah, I have this in .gitconfig:
[core]
abbrev = 12
But I was formatting this not on my laptop and have managed to mislook.
Sorry about "commit" and the breakage.
> > Reported-by: kernel test robot <rong.a.chen@intel.com>
> > Signed-off-by: Dmitry Safonov <dima@arista.com>
>
> Applied, thank you.
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-30 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180730173236.20968-1-dima@arista.com>
2018-07-30 19:43 ` [PATCH] netlink: Don't shift with UB on nlk->ngroups David Miller
2018-07-30 19:50 ` Dmitry Safonov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).