From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dmitry Safonov <dima@arista.com>
Subject: Re: [PATCH 4.4 106/124] netlink: Do not subscribe to non-existent
 groups
Date: Sun, 05 Aug 2018 00:50:31 +0100
Message-ID: <1533426631.2679.155.camel@arista.com>
References: <1533424322.2679.144.camel@arista.com>
         <20180804232102.GA3982@flashbox> <1533425198.2679.148.camel@arista.com>
         <20180804.163348.896647113172060665.davem@davemloft.net>
         <1533426268.2679.152.camel@arista.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: natechancellor@gmail.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        herbert@gondor.apana.org.au, steffen.klassert@secunet.com,
        netdev@vger.kernel.org
To: David Miller <davem@davemloft.net>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1533426268.2679.152.camel@arista.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Sun, 2018-08-05 at 00:44 +0100, Dmitry Safonov wrote:
> On Sat, 2018-08-04 at 16:33 -0700, David Miller wrote:
> > From: Dmitry Safonov <dima@arista.com>
> > Date: Sun, 05 Aug 2018 00:26:38 +0100
> > 
> > > Thanks for the testing, sorry again for the breakage.
> > > Will send the patch shortly (with sizeof(unsigned long long)
> > 
> > instead of
> > > hard-coded 64). Hopefully, not too late.
> > 
> > 'groups' is "long unsigned int" not "unsigned long long"
> > 
> >         long unsigned int groups = nladdr->nl_groups;
> > 
> > And nladdr->nl_groups is specified as "__u32"
> > 
> > So the size of the relevant bits is actually strictly 32-bit.
> > 
> > This makes also the "ULL" in your constant specification incorrect
> > as
> > well.
> > 
> > So much crazy stuff going on here :-/
> 
> Right, I misslooked that..
> How does this work on Android then?
> I doubt they changed uabi.

Ok, I'm too slow - that is 32, but shift does overflow.
Will send the proper patch in a minute.
Sorry about the mess :C