From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dmitry Safonov <dima@arista.com>
Subject: Re: [PATCH] netlink: Don't shift on 64 for ngroups
Date: Sun, 05 Aug 2018 01:37:09 +0100
Message-ID: <1533429429.2679.156.camel@arista.com>
References: <20180804235544.10347-1-dima@arista.com>
         <20180804.170856.2031275734761112973.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, natechancellor@gmail.com,
        herbert@gondor.apana.org.au, steffen.klassert@secunet.com,
        netdev@vger.kernel.org, stable@vger.kernel.org
To: David Miller <davem@davemloft.net>
Return-path: <stable-owner@vger.kernel.org>
In-Reply-To: <20180804.170856.2031275734761112973.davem@davemloft.net>
Sender: stable-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Sat, 2018-08-04 at 17:08 -0700, David Miller wrote:
> From: Dmitry Safonov <dima@arista.com>
> Date: Sun,  5 Aug 2018 00:55:44 +0100
> 
> > @@ -1011,8 +1011,8 @@ static int netlink_bind(struct socket *sock,
> struct sockaddr *addr,
> >  
> >       if (nlk->ngroups == 0)
> >               groups = 0;
> > -     else
> > -             groups &= (1ULL << nlk->ngroups) - 1;
> > +     else if (nlk->ngroups < sizeof(long unsigned int))
> > +             groups &= (1UL << nlk->ngroups) - 1;
> 
> Sizeof is in bytes, you want to compare against bits.

I'm too bad. Drop this version, please.
I've resent v2.