From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhong jiang Subject: [PATCH] drivers/net/usb/r8152: change rtl8152_system_suspend to be void function Date: Wed, 8 Aug 2018 22:26:47 +0800 Message-ID: <1533738407-10495-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , To: , Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org rtl8152_system_suspend defines the variable "ret", but it is not modified after initialization. Further, I find that any of the callees do not handle the return value. So It is safe to drop the variable and make it to be void function. Signed-off-by: zhong jiang --- drivers/net/usb/r8152.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 124211a..cc51ac8 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -4412,10 +4412,9 @@ static int rtl8152_runtime_suspend(struct r8152 *tp) return ret; } -static int rtl8152_system_suspend(struct r8152 *tp) +static void rtl8152_system_suspend(struct r8152 *tp) { struct net_device *netdev = tp->netdev; - int ret = 0; netif_device_detach(netdev); @@ -4429,8 +4428,6 @@ static int rtl8152_system_suspend(struct r8152 *tp) tp->rtl_ops.down(tp); napi_enable(napi); } - - return ret; } static int rtl8152_suspend(struct usb_interface *intf, pm_message_t message) @@ -4443,7 +4440,7 @@ static int rtl8152_suspend(struct usb_interface *intf, pm_message_t message) if (PMSG_IS_AUTO(message)) ret = rtl8152_runtime_suspend(tp); else - ret = rtl8152_system_suspend(tp); + rtl8152_system_suspend(tp); mutex_unlock(&tp->control); -- 1.7.12.4