From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilias Apalodimas Subject: [net-next, PATCH 2/2] net: socionext: Increase descriptors to 256 Date: Thu, 9 Aug 2018 11:02:19 +0300 Message-ID: <1533801739-15312-2-git-send-email-ilias.apalodimas@linaro.org> References: <1533801739-15312-1-git-send-email-ilias.apalodimas@linaro.org> Cc: arnd@arndb.de, Ilias Apalodimas To: netdev@vger.kernel.org, jaswinder.singh@linaro.org Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:35986 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727786AbeHIK0N (ORCPT ); Thu, 9 Aug 2018 06:26:13 -0400 Received: by mail-wm0-f67.google.com with SMTP id w24-v6so5435944wmc.1 for ; Thu, 09 Aug 2018 01:02:34 -0700 (PDT) In-Reply-To: <1533801739-15312-1-git-send-email-ilias.apalodimas@linaro.org> Sender: netdev-owner@vger.kernel.org List-ID: Increasing descriptors to 256 from 128 and adjusting the NAPI weight to 64 increases performace on Rx by ~20% on 64byte packets Signed-off-by: Ilias Apalodimas --- drivers/net/ethernet/socionext/netsec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c index ae32909..5d2007b 100644 --- a/drivers/net/ethernet/socionext/netsec.c +++ b/drivers/net/ethernet/socionext/netsec.c @@ -232,8 +232,7 @@ #define NETSEC_EEPROM_PKT_ME_ADDRESS 0x20 #define NETSEC_EEPROM_PKT_ME_SIZE 0x24 -#define DESC_NUM 128 -#define NAPI_BUDGET (DESC_NUM / 2) +#define DESC_NUM 256 #define DESC_SZ sizeof(struct netsec_de) @@ -1655,7 +1654,7 @@ static int netsec_probe(struct platform_device *pdev) dev_info(&pdev->dev, "hardware revision %d.%d\n", hw_ver >> 16, hw_ver & 0xffff); - netif_napi_add(ndev, &priv->napi, netsec_napi_poll, NAPI_BUDGET); + netif_napi_add(ndev, &priv->napi, netsec_napi_poll, NAPI_POLL_WEIGHT); ndev->netdev_ops = &netsec_netdev_ops; ndev->ethtool_ops = &netsec_ethtool_ops; -- 2.7.4