Netdev List
 help / color / mirror / Atom feed
From: Vlad Buslov <vladbu@mellanox.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
	jiri@resnulli.us, pablo@netfilter.org, kadlec@blackhole.kfki.hu,
	fw@strlen.de, ast@kernel.org, daniel@iogearbox.net,
	edumazet@google.com, keescook@chromium.org,
	marcelo.leitner@gmail.com, Vlad Buslov <vladbu@mellanox.com>
Subject: [PATCH net-next v2 05/15] net: sched: act_ipt: remove dependency on rtnl lock
Date: Fri, 10 Aug 2018 20:51:45 +0300	[thread overview]
Message-ID: <1533923515-5664-6-git-send-email-vladbu@mellanox.com> (raw)
In-Reply-To: <1533923515-5664-1-git-send-email-vladbu@mellanox.com>

Use tcf spinlock to protect ipt action private data from concurrent
modification during dump. Ipt init already takes tcf spinlock when
modifying ipt state.

Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
---
 net/sched/act_ipt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/sched/act_ipt.c b/net/sched/act_ipt.c
index 0dc787a57798..e149f0e66cb6 100644
--- a/net/sched/act_ipt.c
+++ b/net/sched/act_ipt.c
@@ -288,6 +288,7 @@ static int tcf_ipt_dump(struct sk_buff *skb, struct tc_action *a, int bind,
 	 * for foolproof you need to not assume this
 	 */
 
+	spin_lock_bh(&ipt->tcf_lock);
 	t = kmemdup(ipt->tcfi_t, ipt->tcfi_t->u.user.target_size, GFP_ATOMIC);
 	if (unlikely(!t))
 		goto nla_put_failure;
@@ -307,10 +308,12 @@ static int tcf_ipt_dump(struct sk_buff *skb, struct tc_action *a, int bind,
 	if (nla_put_64bit(skb, TCA_IPT_TM, sizeof(tm), &tm, TCA_IPT_PAD))
 		goto nla_put_failure;
 
+	spin_unlock_bh(&ipt->tcf_lock);
 	kfree(t);
 	return skb->len;
 
 nla_put_failure:
+	spin_unlock_bh(&ipt->tcf_lock);
 	nlmsg_trim(skb, b);
 	kfree(t);
 	return -1;
-- 
2.7.5

  parent reply	other threads:[~2018-08-10 20:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10 17:51 [PATCH net-next v2 00/15] Remove rtnl lock dependency from all action implementations Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 01/15] net: sched: act_bpf: remove dependency on rtnl lock Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 02/15] net: sched: act_csum: " Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 03/15] net: sched: act_gact: " Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 04/15] net: sched: act_ife: " Vlad Buslov
2018-08-10 17:51 ` Vlad Buslov [this message]
2018-08-10 17:51 ` [PATCH net-next v2 06/15] net: sched: act_pedit: " Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 07/15] net: sched: act_sample: " Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 08/15] net: sched: act_simple: " Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 09/15] net: sched: act_skbmod: " Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 10/15] net: sched: act_tunnel_key: " Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 11/15] net: sched: act_vlan: " Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 12/15] net: sched: extend action ops with put_dev callback Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 13/15] net: sched: act_mirred: remove dependency on rtnl lock Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 14/15] net: core: protect rate estimator statistics pointer with lock Vlad Buslov
2018-08-10 17:51 ` [PATCH net-next v2 15/15] net: sched: act_police: remove dependency on rtnl lock Vlad Buslov
2018-08-11 19:38 ` [PATCH net-next v2 00/15] Remove rtnl lock dependency from all action implementations David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533923515-5664-6-git-send-email-vladbu@mellanox.com \
    --to=vladbu@mellanox.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=keescook@chromium.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox