From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhong jiang Subject: [PATCHv2 1/2] ethernet: declance: Use NULL to compare with pointer-typed value rather than 0 Date: Sat, 18 Aug 2018 14:32:28 +0800 Message-ID: <1534573949-17548-2-git-send-email-zhongjiang@huawei.com> References: <1534573949-17548-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , , , To: Return-path: Received: from szxga06-in.huawei.com ([45.249.212.32]:57865 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725908AbeHRJvC (ORCPT ); Sat, 18 Aug 2018 05:51:02 -0400 In-Reply-To: <1534573949-17548-1-git-send-email-zhongjiang@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: We should use NULL to compare with pointer-typed value rather than 0. The issue is detected with the help of Coccinelle. Signed-off-by: zhong jiang --- drivers/net/ethernet/amd/declance.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c index 116997a..c636f02 100644 --- a/drivers/net/ethernet/amd/declance.c +++ b/drivers/net/ethernet/amd/declance.c @@ -606,8 +606,7 @@ static int lance_rx(struct net_device *dev) } else { len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4; skb = netdev_alloc_skb(dev, len + 2); - - if (skb == 0) { + if (!skb) { dev->stats.rx_dropped++; *rds_ptr(rd, mblength, lp->type) = 0; *rds_ptr(rd, rmd1, lp->type) = -- 1.7.12.4