From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhong jiang Subject: [PATCHv2 2/2] ethernet: lpc_eth: Use NULL to compare with pointer-typed value rather than 0 Date: Sat, 18 Aug 2018 14:32:29 +0800 Message-ID: <1534573949-17548-3-git-send-email-zhongjiang@huawei.com> References: <1534573949-17548-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , , , To: Return-path: In-Reply-To: <1534573949-17548-1-git-send-email-zhongjiang@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org We should use NULL to compare with pointer-typed value rather than 0. The issue is detected with the help of Coccinelle. Acked-by: Vladimir Zapolskiy Signed-off-by: zhong jiang --- drivers/net/ethernet/nxp/lpc_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 08381ef..1c41b07 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -1350,7 +1350,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) "IRAM not big enough for net buffers, using SDRAM instead.\n"); } - if (pldat->dma_buff_base_v == 0) { + if (!pldat->dma_buff_base_v) { ret = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (ret) goto err_out_free_irq; -- 1.7.12.4