From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH iproute2 1/3] testsuite: remove all temp files and implement make clean Date: Thu, 23 Aug 2018 09:34:31 +0100 Message-ID: <1535013271.5764.117.camel@debian.org> References: <20180822180903.26443-1-bluca@debian.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Uggiy2tIB1RzdbWXbRTf" Cc: stephen@networkplumber.org To: Stefan Bader , netdev@vger.kernel.org Return-path: Received: from mail-wr1-f47.google.com ([209.85.221.47]:40877 "EHLO mail-wr1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729390AbeHWMDI (ORCPT ); Thu, 23 Aug 2018 08:03:08 -0400 Received: by mail-wr1-f47.google.com with SMTP id n2-v6so3876093wrw.7 for ; Thu, 23 Aug 2018 01:34:34 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: --=-Uggiy2tIB1RzdbWXbRTf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2018-08-23 at 09:07 +0200, Stefan Bader wrote: > On 22.08.2018 20:09, Luca Boccassi wrote: > > Some generated test files were not removed, including one > > executable in > > the testsuite/tools directory. > > Ensure make clean from the top level directory works for the > > testsuite > > subdirs too, and that all the files are removed. > >=20 > > Signed-off-by: Luca Boccassi > > --- >=20 > Patch 1+2 look good to me and I would ack if that would count in any > way. > For patch 3 I only wonder whether that might re-use $PREFIX (which is > defined as "sudo -E unshare -n"). Ok, the unshare part might be > slight > overkill, but maybe a little better in style. Not sure though, and it > is high level whining... >=20 > -Stefan Hi, Yeah I thought about that, but as you noticed it would run it through unshare so I changed it in the end. I don't mind either way - Stephen, let me know which one you prefer. --=20 Kind regards, Luca Boccassi --=-Uggiy2tIB1RzdbWXbRTf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAlt+cZcACgkQSylmgFB4 UWLixgf/XKeNTvWUjS5KO3ZxrjQs1tyGU/Vvs43gKNdYj5EogtnP0Mz4xasYmouG rf6CkzVQaaI2Vn38JZiT85zSDCprzhr27v15T/V3DK02c8NoFHP0BL40s/ieT+PW y6wrsI4l58IEMXHDqpY2YNQLPuTcTdrv7Oy4E212O8O74UrTxOFNZwQscJFWs6XG TTZFyTXfTLOKuBwDu+GhiJrJjgaGGae95Hdx52pgoGsaWzGcqXy5kClUQkuEwOWU Q5tLFoxyEbHV5JfiESs0bK1rqPuuYOGcOp+PAoSVsV3KqxANtxI7JgoKZ+uGmGt6 xoR0u5Io74HsnejG5O/ZgWco0Y42Kw== =ZKAD -----END PGP SIGNATURE----- --=-Uggiy2tIB1RzdbWXbRTf--