From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hangbin Liu Subject: [PATCH net] net/ipv6: fix incorrect fib6 gateway info after do redirect Date: Thu, 6 Sep 2018 20:57:46 +0800 Message-ID: <1536238666-5307-1-git-send-email-liuhangbin@gmail.com> Cc: David Ahern , "David S. Miller" , Hangbin Liu To: netdev@vger.kernel.org Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:41291 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727698AbeIFRdg (ORCPT ); Thu, 6 Sep 2018 13:33:36 -0400 Received: by mail-pl1-f194.google.com with SMTP id b12-v6so4948944plr.8 for ; Thu, 06 Sep 2018 05:58:13 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: When receive a redirect message and call rt6_do_redirect(), we allocate a new rt6_info and set new flags and gateway info, but not update these info to fib6_info. Then if a user try to get the route info via `ip route get`, he will still get the old default gateway, because inet6_rtm_getroute() get gateway info from fib6_info. Fixes: 23fb93a4d3f11 ("net/ipv6: Cleanup exception and cache route handling") Reported-by: Jianlin Shi Signed-off-by: Hangbin Liu --- net/ipv6/route.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 18e00ce..3d367c9 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -3446,6 +3446,10 @@ static void rt6_do_redirect(struct dst_entry *dst, struct sock *sk, struct sk_bu goto out; } + /* Update fib6_info from rt6_info */ + from->fib6_flags = rt->rt6i_flags; + from->fib6_nh.nh_gw = rt->rt6i_gateway; + netevent.old = &rt->dst; netevent.new = &nrt->dst; netevent.daddr = &msg->dest; -- 2.5.5