From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH v2 net-next 02/12] net: phy: et1011c: Remove incorrect missing 1000 Half
Date: Mon, 10 Sep 2018 23:52:20 +0200 [thread overview]
Message-ID: <1536616350-15442-3-git-send-email-andrew@lunn.ch> (raw)
In-Reply-To: <1536616350-15442-1-git-send-email-andrew@lunn.ch>
The driver indicates it can do 10/100 full and half duplex, plus 1G
Full. The datasheet indicates 1G half is also supported. So make use
of the standard PHY_GBIT_FEATURES.
It could be, this was added because there is a MAC which does not
support 1G half. Bit this is the wrong place to enforce this.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/et1011c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/et1011c.c b/drivers/net/phy/et1011c.c
index a9a4edfa23c8..ab541c9c56fb 100644
--- a/drivers/net/phy/et1011c.c
+++ b/drivers/net/phy/et1011c.c
@@ -91,7 +91,7 @@ static struct phy_driver et1011c_driver[] = { {
.phy_id = 0x0282f014,
.name = "ET1011C",
.phy_id_mask = 0xfffffff0,
- .features = (PHY_BASIC_FEATURES | SUPPORTED_1000baseT_Full),
+ .features = PHY_GBIT_FEATURES,
.flags = PHY_POLL,
.config_aneg = et1011c_config_aneg,
.read_status = et1011c_read_status,
--
2.19.0.rc1
next prev parent reply other threads:[~2018-09-11 2:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 21:52 [PATCH v2 net-next 00/12] Preparing for phylib limkmodes Andrew Lunn
2018-09-10 21:52 ` [PATCH v2 net-next 01/12] net: phy: ste10Xp: Remove wrong SUPPORTED_Pause Andrew Lunn
2018-09-10 22:51 ` Florian Fainelli
2018-09-10 21:52 ` Andrew Lunn [this message]
2018-09-10 21:52 ` [PATCH v2 net-next 03/12] net: phy: bcm63xx: Allow to be built with COMPILE_TEST Andrew Lunn
2018-09-10 21:52 ` [PATCH v2 net-next 04/12] net: ethernet: Use phy_set_max_speed() to limit advertised speed Andrew Lunn
2018-09-10 21:52 ` [PATCH v2 net-next 05/12] net: ethernet: genet: Fix speed selection Andrew Lunn
2018-09-10 23:50 ` Florian Fainelli
2018-09-11 9:02 ` Sergei Shtylyov
2018-09-11 16:41 ` Florian Fainelli
2018-09-10 21:52 ` [PATCH v2 net-next 06/12] net: ethernet: Fix up drivers masking pause support Andrew Lunn
2018-09-10 21:52 ` [PATCH v2 net-next 07/12] net: ethernet: Add helper to remove a supported link mode Andrew Lunn
2018-09-10 21:52 ` [PATCH v2 net-next 08/12] net: ethernet: Add helper for MACs which support asym pause Andrew Lunn
2018-09-10 21:52 ` [PATCH v2 net-next 09/12] net: ethernet: Add helper for MACs which support pause Andrew Lunn
2018-09-10 21:52 ` [PATCH v2 net-next 10/12] net: ethernet: Add helper for set_pauseparam for Asym Pause Andrew Lunn
2018-09-10 22:52 ` Florian Fainelli
2018-09-11 13:04 ` kbuild test robot
2018-09-10 21:52 ` [PATCH v2 net-next 11/12] net: ethernet: Add helper for set_pauseparam for Pause Andrew Lunn
2018-09-10 22:53 ` Florian Fainelli
2018-09-11 21:01 ` kbuild test robot
2018-09-10 21:52 ` [PATCH v2 net-next 12/12] net: ethernet: Add helper to determine if pause configuration is supported Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536616350-15442-3-git-send-email-andrew@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).