From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roopa Prabhu Subject: [PATCH net] net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags Date: Wed, 12 Sep 2018 13:21:48 -0700 Message-ID: <1536783708-21949-1-git-send-email-roopa@cumulusnetworks.com> Cc: netdev@vger.kernel.org, stephen@networkplumber.org, liam.mcbirnie@boeing.com To: davem@davemloft.net Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:33695 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbeIMB2D (ORCPT ); Wed, 12 Sep 2018 21:28:03 -0400 Received: by mail-pl1-f193.google.com with SMTP id b30-v6so1522335pla.0 for ; Wed, 12 Sep 2018 13:21:53 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: From: Roopa Prabhu This fix addresses https://bugzilla.kernel.org/show_bug.cgi?id=201071 Commit 5025f7f7d506 wrongly relied on __dev_change_flags to notify users of dev flag changes in the case when dev->rtnl_link_state = RTNL_LINK_INITIALIZED. Fix it by indicating flag changes explicitly to __dev_notify_flags. Fixes: 5025f7f7d506 ("rtnetlink: add rtnl_link_state check in rtnl_configure_link") Reported-By: Liam mcbirnie Signed-off-by: Roopa Prabhu --- Dave, if 5025f7f7d506 made it to stable, request you to pls queue this one up too. Thanks. net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 60c9288..63ce2283 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -2810,7 +2810,7 @@ int rtnl_configure_link(struct net_device *dev, const struct ifinfomsg *ifm) } if (dev->rtnl_link_state == RTNL_LINK_INITIALIZED) { - __dev_notify_flags(dev, old_flags, 0U); + __dev_notify_flags(dev, old_flags, (old_flags ^ dev->flags)); } else { dev->rtnl_link_state = RTNL_LINK_INITIALIZED; __dev_notify_flags(dev, old_flags, ~0U); -- 2.1.4