* [PATCH] net: ethernet: remove redundant null pointer check before of_node_put
@ 2018-09-16 13:13 zhong jiang
2018-09-16 21:11 ` Vladimir Zapolskiy
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: zhong jiang @ 2018-09-16 13:13 UTC (permalink / raw)
To: davem; +Cc: fugang.duan, netdev, linux-kernel
of_node_put has taken the null pinter check into account. So it is
safe to remove the duplicated check before of_node_put.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/ethernet/freescale/fec_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 2708297..67d6c9d 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2055,8 +2055,7 @@ static int fec_enet_mii_init(struct platform_device *pdev)
node = of_get_child_by_name(pdev->dev.of_node, "mdio");
err = of_mdiobus_register(fep->mii_bus, node);
- if (node)
- of_node_put(node);
+ of_node_put(node);
if (err)
goto err_out_free_mdiobus;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net: ethernet: remove redundant null pointer check before of_node_put
2018-09-16 13:13 [PATCH] net: ethernet: remove redundant null pointer check before of_node_put zhong jiang
@ 2018-09-16 21:11 ` Vladimir Zapolskiy
2018-09-17 1:55 ` Andy Duan
2018-09-17 15:20 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Zapolskiy @ 2018-09-16 21:11 UTC (permalink / raw)
To: zhong jiang, davem; +Cc: fugang.duan, netdev, linux-kernel
On 09/16/2018 04:13 PM, zhong jiang wrote:
> of_node_put has taken the null pinter check into account. So it is
> safe to remove the duplicated check before of_node_put.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
typo in the commit message, s/pinter/pointer/
Other than that please feel free to add my
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net: ethernet: remove redundant null pointer check before of_node_put
2018-09-16 13:13 [PATCH] net: ethernet: remove redundant null pointer check before of_node_put zhong jiang
2018-09-16 21:11 ` Vladimir Zapolskiy
@ 2018-09-17 1:55 ` Andy Duan
2018-09-17 15:20 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andy Duan @ 2018-09-17 1:55 UTC (permalink / raw)
To: zhong jiang, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
From: zhong jiang <zhongjiang@huawei.com> Sent: 2018年9月16日 21:14
> of_node_put has taken the null pinter check into account. So it is safe to
> remove the duplicated check before of_node_put.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 2708297..67d6c9d 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2055,8 +2055,7 @@ static int fec_enet_mii_init(struct
> platform_device *pdev)
>
> node = of_get_child_by_name(pdev->dev.of_node, "mdio");
> err = of_mdiobus_register(fep->mii_bus, node);
> - if (node)
> - of_node_put(node);
> + of_node_put(node);
> if (err)
> goto err_out_free_mdiobus;
>
> --
> 1.7.12.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ethernet: remove redundant null pointer check before of_node_put
2018-09-16 13:13 [PATCH] net: ethernet: remove redundant null pointer check before of_node_put zhong jiang
2018-09-16 21:11 ` Vladimir Zapolskiy
2018-09-17 1:55 ` Andy Duan
@ 2018-09-17 15:20 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-09-17 15:20 UTC (permalink / raw)
To: zhongjiang; +Cc: fugang.duan, netdev, linux-kernel
From: zhong jiang <zhongjiang@huawei.com>
Date: Sun, 16 Sep 2018 21:13:42 +0800
> of_node_put has taken the null pinter check into account. So it is
> safe to remove the duplicated check before of_node_put.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-17 15:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-16 13:13 [PATCH] net: ethernet: remove redundant null pointer check before of_node_put zhong jiang
2018-09-16 21:11 ` Vladimir Zapolskiy
2018-09-17 1:55 ` Andy Duan
2018-09-17 15:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).