From: Johannes Berg <johannes@sipsolutions.net>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
David Ahern <dsahern@gmail.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 5/7] netlink: prepare validate extack setting for recursion
Date: Wed, 19 Sep 2018 21:09:49 +0200 [thread overview]
Message-ID: <1537384189.10305.58.camel@sipsolutions.net> (raw)
In-Reply-To: <20180919190851.GM4590@localhost.localdomain> (sfid-20180919_210856_964991_06B14B8E)
On Wed, 2018-09-19 at 16:08 -0300, Marcelo Ricardo Leitner wrote:
>
> > If it fails and returns (nested and all) on the first failure it should
> > be fine. I was thinking something like this (whitespace damaged on paste):
>
> This will avoid the situation that we were discussing in the older
> thread, btw.
I think it only avoids the part where we have to worry about "have I
already set this" - which is David's point AFAICT.
I'll reply over to your other email (as I already started writing a
reply there)
johannes
next prev parent reply other threads:[~2018-09-20 0:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 12:08 [PATCH 0/7] netlink recursive policy validation Johannes Berg
2018-09-19 12:08 ` [PATCH 1/7] netlink: remove NLA_NESTED_COMPAT Johannes Berg
2018-09-19 12:08 ` [PATCH 2/7] netlink: make validation_data const Johannes Berg
2018-09-19 16:21 ` David Ahern
2018-09-19 12:08 ` [PATCH 3/7] netlink: set extack error message in nla_validate() Johannes Berg
2018-09-19 16:20 ` David Ahern
2018-09-19 16:31 ` Johannes Berg
2018-09-19 12:08 ` [PATCH 4/7] netlink: combine validate/parse functions Johannes Berg
2018-09-19 12:08 ` [PATCH 5/7] netlink: prepare validate extack setting for recursion Johannes Berg
2018-09-19 16:28 ` David Ahern
2018-09-19 16:36 ` Johannes Berg
[not found] ` <1537374995.10305.47.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-09-19 16:44 ` David Ahern
2018-09-19 19:08 ` Marcelo Ricardo Leitner
2018-09-19 19:09 ` Johannes Berg [this message]
2018-09-19 12:08 ` [PATCH 6/7] netlink: allow NLA_NESTED to specify nested policy to validate Johannes Berg
2018-09-19 12:09 ` [PATCH 7/7] netlink: add nested array policy validation Johannes Berg
2018-09-19 12:15 ` [PATCH 0/7] netlink recursive " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537384189.10305.58.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dsahern@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).