From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhong jiang Subject: [PATCH] mISDN: remove redundant null pointer check before kfree_skb Date: Thu, 20 Sep 2018 22:27:28 +0800 Message-ID: <1537453648-54132-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , , , To: Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org kfree_skb has taken the null pointer into account. hence it is safe to remove the redundant null pointer check before kfree_skb. Signed-off-by: zhong jiang --- drivers/isdn/mISDN/socket.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c index 18c0a12..15d3ca3 100644 --- a/drivers/isdn/mISDN/socket.c +++ b/drivers/isdn/mISDN/socket.c @@ -236,8 +236,7 @@ static void mISDN_sock_unlink(struct mISDN_sock_list *l, struct sock *sk) } done: - if (skb) - kfree_skb(skb); + kfree_skb(skb); release_sock(sk); return err; } -- 1.7.12.4