From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eran Ben Elisha Subject: [PATCH ethtool] ethtool: Fix uninitialized variable use at qsfp dump Date: Thu, 27 Sep 2018 16:48:35 +0300 Message-ID: <1538056115-6677-1-git-send-email-eranbe@mellanox.com> Cc: Chris Preimesberger , Andrew Lunn , Neil Horman , Vidya Sagar Ravipati , Eran Ben Elisha To: netdev@vger.kernel.org, "John W. Linville" Return-path: Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:45452 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727076AbeI0UHJ (ORCPT ); Thu, 27 Sep 2018 16:07:09 -0400 Sender: netdev-owner@vger.kernel.org List-ID: Struct sff_diags can be used uninitialized at sff8636_show_dom, this caused the tool to show unreported fields (supports_alarms) by the lower level driver. Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information Support") Signed-off-by: Eran Ben Elisha --- qsfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qsfp.c b/qsfp.c index 32e195d12dc0..d196aa1753de 100644 --- a/qsfp.c +++ b/qsfp.c @@ -671,7 +671,7 @@ static void sff8636_dom_parse(const __u8 *id, struct sff_diags *sd) static void sff8636_show_dom(const __u8 *id, __u32 eeprom_len) { - struct sff_diags sd; + struct sff_diags sd = {0}; char *rx_power_string = NULL; char power_string[MAX_DESC_SIZE]; int i; -- 1.8.3.1