From: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
To: davem@davemloft.net
Cc: michael.chan@broadcom.com, netdev@vger.kernel.org,
jiri@mellanox.com, jakub.kicinski@netronome.com
Subject: [PATCH v3 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED
Date: Fri, 28 Sep 2018 11:58:19 +0530 [thread overview]
Message-ID: <1538116103-12356-6-git-send-email-vasundhara-v.volam@broadcom.com> (raw)
In-Reply-To: <1538116103-12356-1-git-send-email-vasundhara-v.volam@broadcom.com>
Return proper error code when Firmware returns
HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED for HWRM_NVM_GET/SET_VARIABLE
commands.
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index 5173881..dc566fd 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -80,8 +80,12 @@ static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param_id, void *msg,
memcpy(buf, data_addr, bytesize);
dma_free_coherent(&bp->pdev->dev, bytesize, data_addr, data_dma_addr);
- if (rc)
+ if (rc == HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED) {
+ netdev_err(bp->dev, "PF does not have admin privileges to modify NVM config\n");
+ return -EACCES;
+ } else if (rc) {
return -EIO;
+ }
return 0;
}
--
1.8.3.1
next prev parent reply other threads:[~2018-09-28 12:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 6:28 [PATCH v3 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
2018-09-28 6:28 ` [PATCH v3 net-next 1/9] devlink: Add generic parameter ignore_ari Vasundhara Volam
2018-09-28 6:28 ` [PATCH v3 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max Vasundhara Volam
2018-09-28 6:28 ` [PATCH v3 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min Vasundhara Volam
2018-09-28 6:28 ` [PATCH v3 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter Vasundhara Volam
2018-09-29 21:22 ` Or Gerlitz
2018-10-01 4:09 ` Vasundhara Volam
2018-09-28 6:28 ` Vasundhara Volam [this message]
2018-09-28 6:28 ` [PATCH v3 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params Vasundhara Volam
2018-09-28 6:28 ` [PATCH v3 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter Vasundhara Volam
2018-09-28 6:28 ` [PATCH v3 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt Vasundhara Volam
2018-09-28 6:28 ` [PATCH v3 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt Vasundhara Volam
2018-09-29 12:53 ` Jiri Pirko
2018-10-01 4:04 ` Vasundhara Volam
2018-10-01 6:49 ` Jiri Pirko
2018-10-01 6:57 ` Vasundhara Volam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538116103-12356-6-git-send-email-vasundhara-v.volam@broadcom.com \
--to=vasundhara-v.volam@broadcom.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox