From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li RongQing Subject: [PATCH] xfrm: fix gro_cells leak when remove virtual xfrm interfaces Date: Sun, 30 Sep 2018 15:06:06 +0800 Message-ID: <1538291166-14645-1-git-send-email-lirongqing@baidu.com> To: netdev@vger.kernel.org, steffen.klassert@secunet.com Return-path: Received: from mx133-tc.baidu.com ([61.135.168.133]:24200 "EHLO tc-sys-mailedm05.tc.baidu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727651AbeI3NiR (ORCPT ); Sun, 30 Sep 2018 09:38:17 -0400 Sender: netdev-owner@vger.kernel.org List-ID: The device gro_cells has been initialized, it should be freed, otherwise it will be leaked Fixes: f203b76d78092faf2 ("xfrm: Add virtual xfrm interfaces") Signed-off-by: Zhang Yu Signed-off-by: Li RongQing --- net/xfrm/xfrm_interface.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c index 4b4ef4f662d9..9cc6e72bc802 100644 --- a/net/xfrm/xfrm_interface.c +++ b/net/xfrm/xfrm_interface.c @@ -116,6 +116,9 @@ static void xfrmi_unlink(struct xfrmi_net *xfrmn, struct xfrm_if *xi) static void xfrmi_dev_free(struct net_device *dev) { + struct xfrm_if *xi = netdev_priv(dev); + + gro_cells_destroy(&xi->gro_cells); free_percpu(dev->tstats); } -- 2.16.2