From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH net-next 04/19] net: usb: aqc111: Various callbacks implementation Date: Mon, 08 Oct 2018 15:47:14 +0200 Message-ID: <1539006434.10342.14.camel@suse.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Dmitry Bezrukov , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" To: Igor Russkikh , "David S . Miller" Return-path: Received: from mx2.suse.de ([195.135.220.15]:51252 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726078AbeJHVHz (ORCPT ); Mon, 8 Oct 2018 17:07:55 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Fr, 2018-10-05 at 10:24 +0000, Igor Russkikh wrote: > From: Dmitry Bezrukov > > Reset, stop callbacks, driver unbind callback. > More register defines required for these callbacks. > > Signed-off-by: Dmitry Bezrukov > Signed-off-by: Igor Russkikh > --- > drivers/net/usb/aqc111.c | 48 ++++++++++++++++++++++ > drivers/net/usb/aqc111.h | 101 +++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 149 insertions(+) > > diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c > index 7f3e5a615750..22bb259d71fb 100644 > --- a/drivers/net/usb/aqc111.c > +++ b/drivers/net/usb/aqc111.c > @@ -169,12 +169,60 @@ static int aqc111_bind(struct usbnet *dev, struct usb_interface *intf) > > static void aqc111_unbind(struct usbnet *dev, struct usb_interface *intf) > { > + u8 reg8; > + u16 reg16; > + > + /* Force bz */ > + reg16 = SFR_PHYPWR_RSTCTL_BZ; > + aqc111_write_cmd_nopm(dev, AQ_ACCESS_MAC, SFR_PHYPWR_RSTCTL, > + 2, 2, ®16); No, I am sorry, you are doing DMA on the kernel stack. That is not allowed. These functions will all have to be fixed. Regards Oliver