netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Whitten <ben.whitten@gmail.com>
To: afaerber@suse.de
Cc: starnight@g.ncu.edu.tw, hasnain.virk@arm.com,
	netdev@vger.kernel.org, liuxuenetmail@gmail.com,
	shess@hessware.de, Ben Whitten <ben.whitten@lairdtech.com>
Subject: [PATCH v2 lora-next 0/4] migration to regmap and clk framework
Date: Tue,  9 Oct 2018 13:52:08 +0100	[thread overview]
Message-ID: <1539089532-2481-1-git-send-email-ben.whitten@lairdtech.com> (raw)

This series completes the sx1301 migration to regmap by replaceing the SPI
burst read and write with regmap raw reads and writes, this solution is a work
around until there is regmap_noinc_read/write API merged as it sepends on the
fact that we have the regcache turned off.
regmap_noinc_read is available in 4.19 however a write varient isn't.

The various fields of the sx1301 are converted to regmap to pass the read
modify write down to the regmap layer and reduce our code.
The downside is that in the cases of the hand optimised multiple field writes
at once within one register, however if it is desirable these can be replaced
with regmap_update_bits.

Apply the same regmap treatment for the radio device and allow it to register as
a clock provider, this clock is enabled when the lora link is brought up as it
is required prior to calibration of the concentrator.

modprobe lora-sx125x
lora-dev: init
sx1301 spi0.0: SX1301 module probed
sx125x_con spi0.0-a: SX125x version: 21
sx125x_con spi0.0-a: SX125x module probed
sx125x_con spi0.0-b: SX125x version: 21
sx125x_con spi0.0-b: registering clkout
sx125x_con spi0.0-b: SX125x module probed

ip link set lora0 up
sx125x_con spi0.0-b: enabling clkout

Ben Whitten (4):
  net: lora: sx1301: convert burst spi functions to regmap raw
  net: lora: sx1301: convert to using regmap fields for bit ops
  net: lora: sx125x: convert to regmap fields
  net: lora: sx125x sx1301: allow radio to register as a clk provider

 drivers/net/lora/sx125x.c | 159 ++++++++++++++++++++++++++--
 drivers/net/lora/sx1301.c | 265 ++++++++++++++++------------------------------
 drivers/net/lora/sx1301.h |  50 ++++++++-
 3 files changed, 287 insertions(+), 187 deletions(-)

-- 
2.7.4

             reply	other threads:[~2018-10-09 20:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09 12:52 Ben Whitten [this message]
2018-10-09 12:52 ` [PATCH v2 lora-next 1/4] net: lora: sx1301: convert burst spi functions to regmap raw Ben Whitten
2018-10-10  7:59   ` Andreas Färber
2018-10-10  9:22     ` Ben Whitten
2018-10-10 10:19     ` Mark Brown
2018-10-09 12:52 ` [PATCH v2 lora-next 2/4] net: lora: sx1301: convert to using regmap fields for bit ops Ben Whitten
2018-10-09 12:52 ` [PATCH v2 lora-next 3/4] net: lora: sx125x: convert to regmap fields Ben Whitten
2018-10-09 12:52 ` [PATCH v2 lora-next 4/4] net: lora: sx125x sx1301: allow radio to register as a clk provider Ben Whitten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539089532-2481-1-git-send-email-ben.whitten@lairdtech.com \
    --to=ben.whitten@gmail.com \
    --cc=afaerber@suse.de \
    --cc=ben.whitten@lairdtech.com \
    --cc=hasnain.virk@arm.com \
    --cc=liuxuenetmail@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=shess@hessware.de \
    --cc=starnight@g.ncu.edu.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).