From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serhey Popovych Subject: [PATCH net-next] tun: Consistently configure generic netdev params via rtnetlink Date: Tue, 9 Oct 2018 21:21:01 +0300 Message-ID: <1539109261-8414-1-git-send-email-serhe.popovych@gmail.com> Cc: ebiederm@xmission.com To: netdev@vger.kernel.org Return-path: Received: from mail-lf1-f66.google.com ([209.85.167.66]:38537 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbeJJBpK (ORCPT ); Tue, 9 Oct 2018 21:45:10 -0400 Received: by mail-lf1-f66.google.com with SMTP id g89-v6so2011359lfl.5 for ; Tue, 09 Oct 2018 11:26:53 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: Configuring generic network device parameters on tun will fail in presence of IFLA_INFO_KIND attribute in IFLA_LINKINFO nested attribute since tun_validate() always return failure. This can be visualized with following ip-link(8) command sequences: # ip link set dev tun0 group 100 # ip link set dev tun0 group 100 type tun RTNETLINK answers: Invalid argument with contrast to dummy and veth drivers: # ip link set dev dummy0 group 100 # ip link set dev dummy0 type dummy # ip link set dev veth0 group 100 # ip link set dev veth0 group 100 type veth Fix by returning zero in tun_validate() when @data is NULL that is always in case since rtnl_link_ops->maxtype is zero in tun driver. Fixes: f019a7a594d9 ("tun: Implement ip link del tunXXX") Signed-off-by: Serhey Popovych --- drivers/net/tun.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index b174342..a3e8a43 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -2298,6 +2298,8 @@ static void tun_setup(struct net_device *dev) static int tun_validate(struct nlattr *tb[], struct nlattr *data[], struct netlink_ext_ack *extack) { + if (!data) + return 0; return -EINVAL; } -- 1.8.3.1