From: Oliver Neukum <oneukum@suse.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
davem@davemloft.net, netdev@vger.kernel.org
Cc: gregkh@linuxfoundation.org, linux-kernel@lists.codethink.co.uk,
bjorn@mork.no, steve.glendinning@shawell.net,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: usbnet private-data accessor functions
Date: Fri, 12 Oct 2018 17:38:48 +0200 [thread overview]
Message-ID: <1539358728.2802.3.camel@suse.com> (raw)
In-Reply-To: <20181012091642.21294-1-ben.dooks@codethink.co.uk>
On Fr, 2018-10-12 at 10:16 +0100, Ben Dooks wrote:
> I have been looking at the usbnet drivers and the possibility of some
> code cleanups. One of the things I've found is that changing the way
> the drivers use the private data with the usbnet structure is often
> hand-coded each time is needed.
Where is the improvement? You are just hiding how the data is passed.
It may look more pleasant to you, but that is a subjective impression.
I would suggest that if you want a nicely named way to get at private
data, add a field to the appropriate data structure.
Regards
Oliver
prev parent reply other threads:[~2018-10-12 15:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 9:16 usbnet private-data accessor functions Ben Dooks
2018-10-12 9:16 ` [PATCH 1/7] net: smsc75xx: add usbnet -> priv function Ben Dooks
2018-10-12 10:19 ` Greg KH
2018-10-12 9:16 ` [PATCH 2/7] net: asix: " Ben Dooks
2018-10-12 10:20 ` Greg KH
2018-10-12 9:16 ` [PATCH 3/7] net: usb: asix88179_178a: " Ben Dooks
2018-10-12 10:20 ` Greg KH
2018-10-12 9:16 ` [PATCH 4/7] net: qmi_wwan: " Ben Dooks
2018-10-12 10:20 ` Greg KH
2018-10-12 10:44 ` Bjørn Mork
2018-10-12 13:22 ` Ben Dooks
2018-10-12 9:16 ` [PATCH 5/7] net: cdc_ether: " Ben Dooks
2018-10-12 10:20 ` Greg KH
2018-10-12 9:16 ` [PATCH 6/7] net: huawei_cdc_ncm: " Ben Dooks
2018-10-12 10:20 ` Greg KH
2018-10-12 9:16 ` [PATCH 7/7] net: usb: sr9800: " Ben Dooks
2018-10-12 10:20 ` Greg KH
2018-10-12 15:38 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539358728.2802.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=ben.dooks@codethink.co.uk \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).