From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH iproute2] Use libbsd for strlcpy if available Date: Mon, 29 Oct 2018 15:37:51 +0000 Message-ID: <1540827471.29722.9.camel@debian.org> References: <20181029104650.24924-1-bluca@debian.org> <78a4e635-1675-a92d-e7ba-ffc4a642b901@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-rTnUKAk5T5IhEXEkKnAQ" Cc: stephen@networkplumber.org To: David Ahern , netdev@vger.kernel.org Return-path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:42764 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726763AbeJ3A1D (ORCPT ); Mon, 29 Oct 2018 20:27:03 -0400 Received: by mail-wr1-f67.google.com with SMTP id y15-v6so9199333wru.9 for ; Mon, 29 Oct 2018 08:37:55 -0700 (PDT) In-Reply-To: <78a4e635-1675-a92d-e7ba-ffc4a642b901@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: --=-rTnUKAk5T5IhEXEkKnAQ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2018-10-29 at 09:27 -0600, David Ahern wrote: > On 10/29/18 4:46 AM, Luca Boccassi wrote: > > If libc does not provide strlcpy check for libbsd with pkg-config > > to > > avoid relying on inline version. > >=20 > > Signed-off-by: Luca Boccassi > > --- > > This allows distro maintainers to be able to choose to reduce > > duplication and let this code be maintained in one place, in the > > external library. > >=20 > > =C2=A0configure | 12 ++++++++++-- > > =C2=A01 file changed, 10 insertions(+), 2 deletions(-) > >=20 > > diff --git a/configure b/configure > > index 744d6282..1dd9ce84 100755 > > --- a/configure > > +++ b/configure > > @@ -330,8 +330,16 @@ EOF > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0then > > =C2=A0 echo "no" > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else > > - echo 'CFLAGS +=3D -DNEED_STRLCPY' >>$CONFIG > > - echo "yes" > > + if ${PKG_CONFIG} libbsd --exists > > + then > > + echo 'CFLAGS +=3D -include' `${PKG_CONFIG} libbsd -- > > variable=3Dincludedir`'/bsd/string.h' \ > > + `${PKG_CONFIG} libbsd --cflags` >>$CONFIG > > + echo 'LDLIBS +=3D' `${PKG_CONFIG} libbsd --libs` >> > > $CONFIG > > + echo "no" > > + else > > + echo 'CFLAGS +=3D -DNEED_STRLCPY' >>$CONFIG > > + echo "yes" > > + fi > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0fi > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0rm -f $TMPDIR/strtest.c $TMPDIR/strtest > > =C2=A0} > >=20 >=20 > How long has libbsd had an implementation of strlcpy? Would be safer > to > have a compile test to verify libbsd has it. Hi, 0.0 from 10+ years ago has it, so I think we are safe :-) https://gitlab.freedesktop.org/libbsd/libbsd/blob/0.0/include/bsd/string.h#= L34 --=20 Kind regards, Luca Boccassi --=-rTnUKAk5T5IhEXEkKnAQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAlvXKU8ACgkQSylmgFB4 UWJmuQf/S6z2TUVzjOmElo2N9PiQ0aMrWFNoZF8xzbMi1YKKZsCXDcuYrbFrkFn1 Thxpt5lEx1PlL6Bs3Bfr2EDyBFmlHng/61zfulBwPtDIy0HtyMyLdAYNNsi+Lf8f JvTbF98A03gZhZnoqhafETJFsAi5m6NmOJnSWeVxyoods4Gf04R5mbFc66NO9zvA /imajfifeZexd4zOFJITuSCd64xIqTyvR0UEriJSKbmcuaz1qXpsoplOWFpJFKsu iBnJtidJtU+ZUbjEt6+B7pGcYzZQblu6QOr6RvQ9XfsZtenUQ/D+mqm0OuV2sPTM uy2dnMBQW97iY7/7ONXMI6/m+n87wQ== =kXwn -----END PGP SIGNATURE----- --=-rTnUKAk5T5IhEXEkKnAQ--