From: Luca Boccassi <bluca@debian.org>
To: Edward Cree <ecree@solarflare.com>, netdev@vger.kernel.org
Cc: stephen@networkplumber.org, dsahern@gmail.com
Subject: Re: [PATCH iproute2] Fix warning in tc-skbprio.8 manpage
Date: Fri, 02 Nov 2018 15:28:06 +0000 [thread overview]
Message-ID: <1541172486.4849.23.camel@debian.org> (raw)
In-Reply-To: <d6165e95-06bf-b835-21ae-f0a1f744bec6@solarflare.com>
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
On Fri, 2018-11-02 at 15:19 +0000, Edward Cree wrote:
> On 02/11/18 10:57, Luca Boccassi wrote:
> > ". If" gets interpreted as a macro, so move the period to the
> > previous
> > line:
> >
> > 33: warning: macro `If' not defined
> >
> > Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > man/man8/tc-skbprio.8 | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/man/man8/tc-skbprio.8 b/man/man8/tc-skbprio.8
> > index 844bbf46..8b259839 100644
> > --- a/man/man8/tc-skbprio.8
> > +++ b/man/man8/tc-skbprio.8
> > @@ -29,8 +29,8 @@ While SKB Priority Queue is agnostic to how
> > .B skb->priority
> > is assigned. A typical use case is to copy
> > the 6-bit DS field of IPv4 and IPv6 packets using
> > -.BR tc-skbedit (8)
> > -. If
> > +.BR tc-skbedit (8) .
> > +If
>
> Won't that make the full-stop bold?
> Removing the space, i.e.
> .BR rc-skbedit (8).
> ought to work.
> -Ed
Yes you are right, fixed in v2, thanks.
--
Kind regards,
Luca Boccassi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-03 0:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 10:57 [PATCH iproute2] Fix warning in tc-skbprio.8 manpage Luca Boccassi
2018-11-02 15:19 ` Edward Cree
2018-11-02 15:28 ` Luca Boccassi [this message]
2018-11-02 15:27 ` [PATCH iproute2 v2] " Luca Boccassi
2018-11-09 16:06 ` [PATCH iproute2] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541172486.4849.23.camel@debian.org \
--to=bluca@debian.org \
--cc=dsahern@gmail.com \
--cc=ecree@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).