* [PATCH net] igb: fix uninitialized variables
@ 2018-11-06 8:27 wangyunjian
2018-11-15 0:12 ` [Intel-wired-lan] " Brown, Aaron F
0 siblings, 1 reply; 2+ messages in thread
From: wangyunjian @ 2018-11-06 8:27 UTC (permalink / raw)
To: netdev, intel-wired-lan; +Cc: stone.zhou, Yunjian Wang
From: Yunjian Wang <wangyunjian@huawei.com>
This patch fixes the variable 'phy_word' may be used uninitialized.
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/net/ethernet/intel/igb/e1000_i210.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/igb/e1000_i210.c b/drivers/net/ethernet/intel/igb/e1000_i210.c
index c54ebed..c393cb2 100644
--- a/drivers/net/ethernet/intel/igb/e1000_i210.c
+++ b/drivers/net/ethernet/intel/igb/e1000_i210.c
@@ -842,6 +842,7 @@ s32 igb_pll_workaround_i210(struct e1000_hw *hw)
nvm_word = E1000_INVM_DEFAULT_AL;
tmp_nvm = nvm_word | E1000_INVM_PLL_WO_VAL;
igb_write_phy_reg_82580(hw, I347AT4_PAGE_SELECT, E1000_PHY_PLL_FREQ_PAGE);
+ phy_word = E1000_PHY_PLL_UNCONF;
for (i = 0; i < E1000_MAX_PLL_TRIES; i++) {
/* check current state directly from internal PHY */
igb_read_phy_reg_82580(hw, E1000_PHY_PLL_FREQ_REG, &phy_word);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [Intel-wired-lan] [PATCH net] igb: fix uninitialized variables
2018-11-06 8:27 [PATCH net] igb: fix uninitialized variables wangyunjian
@ 2018-11-15 0:12 ` Brown, Aaron F
0 siblings, 0 replies; 2+ messages in thread
From: Brown, Aaron F @ 2018-11-15 0:12 UTC (permalink / raw)
To: wangyunjian, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org
Cc: stone.zhou@huawei.com
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
> Behalf Of wangyunjian
> Sent: Tuesday, November 6, 2018 12:27 AM
> To: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org
> Cc: stone.zhou@huawei.com; Yunjian Wang <wangyunjian@huawei.com>
> Subject: [Intel-wired-lan] [PATCH net] igb: fix uninitialized variables
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This patch fixes the variable 'phy_word' may be used uninitialized.
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> drivers/net/ethernet/intel/igb/e1000_i210.c | 1 +
> 1 file changed, 1 insertion(+)
>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-15 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-06 8:27 [PATCH net] igb: fix uninitialized variables wangyunjian
2018-11-15 0:12 ` [Intel-wired-lan] " Brown, Aaron F
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).