From: Suraj Singh <suraj1998@gmail.com>
To: davem@davemloft.net
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Suraj Singh <suraj998@gmail.com>
Subject: Re: net: ipv4: tcp_westwood: fixed warnings and checks
Date: Thu, 8 Nov 2018 14:38:12 +0530 [thread overview]
Message-ID: <1541668092-8661-1-git-send-email-suraj1998@gmail.com> (raw)
In-Reply-To: <1541425985-31869-1-git-send-email-suraj1998@gmail.com--annotate>
From: Suraj Singh <suraj998@gmail.com>
Regrding why I used "staging: " in the commmit message, I was following Greg Kroah-Hartman's video on YouTube on how to submit your first patch, and in his sample commit, he'd started his commit message with "staging: ", and so I thought it was convention to do so. I'll remove that immediately. I made this same mistake in another patch that I just sent for TCP Vegas, I'll make the change there as well.
I didn't consider the complexities of calling the same function twice. I was looking more towards satisying the scriptpatch.pl's requirements.
- tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
+ tp->snd_cwnd = tcp_westwood_bw_rttmin(sk);
+ tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
I've made the same mistake here. I'll make these changes and resubmit. Is there anything else that's wrong?
next parent reply other threads:[~2018-11-08 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1541425985-31869-1-git-send-email-suraj1998@gmail.com--annotate>
2018-11-08 9:08 ` Suraj Singh [this message]
2018-11-05 13:53 [PATCH] staging: net: ipv4: tcp_westwood: fixed warnings and checks Suraj Singh
2018-11-08 9:16 ` Suraj Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541668092-8661-1-git-send-email-suraj1998@gmail.com \
--to=suraj1998@gmail.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=suraj998@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).