From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suraj Singh Subject: Re: net: ipv4: tcp_westwood: fixed warnings and checks Date: Thu, 8 Nov 2018 14:38:12 +0530 Message-ID: <1541668092-8661-1-git-send-email-suraj1998@gmail.com> References: <1541425985-31869-1-git-send-email-suraj1998@gmail.com--annotate> Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Suraj Singh To: davem@davemloft.net Return-path: In-Reply-To: <1541425985-31869-1-git-send-email-suraj1998@gmail.com--annotate> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Suraj Singh Regrding why I used "staging: " in the commmit message, I was following Greg Kroah-Hartman's video on YouTube on how to submit your first patch, and in his sample commit, he'd started his commit message with "staging: ", and so I thought it was convention to do so. I'll remove that immediately. I made this same mistake in another patch that I just sent for TCP Vegas, I'll make the change there as well. I didn't consider the complexities of calling the same function twice. I was looking more towards satisying the scriptpatch.pl's requirements. - tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk); + tp->snd_cwnd = tcp_westwood_bw_rttmin(sk); + tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk); I've made the same mistake here. I'll make these changes and resubmit. Is there anything else that's wrong?