From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li RongQing Subject: [PATCH][net-next][v2] net: remove BUG_ON from __pskb_pull_tail Date: Tue, 13 Nov 2018 09:16:52 +0800 Message-ID: <1542071812-14338-1-git-send-email-lirongqing@baidu.com> To: netdev@vger.kernel.org Return-path: Received: from mx57.baidu.com ([61.135.168.57]:23483 "EHLO tc-sys-mailedm03.tc.baidu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725991AbeKMLMr (ORCPT ); Tue, 13 Nov 2018 06:12:47 -0500 Received: from localhost (cp01-cos-dev01.cp01.baidu.com [10.92.119.46]) by tc-sys-mailedm03.tc.baidu.com (Postfix) with ESMTP id 467ED624004 for ; Tue, 13 Nov 2018 09:16:52 +0800 (CST) Sender: netdev-owner@vger.kernel.org List-ID: if list is NULL pointer, and the following access of list will trigger panic, which is same as BUG_ON Signed-off-by: Li RongQing --- net/core/skbuff.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 396fcb3baad0..d69503d66021 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -1925,8 +1925,6 @@ void *__pskb_pull_tail(struct sk_buff *skb, int delta) struct sk_buff *insp = NULL; do { - BUG_ON(!list); - if (list->len <= eat) { /* Eaten as whole. */ eat -= list->len; -- 2.16.2